Permalink
Commits on Mar 31, 2015
  1. [docs] Fix typo.

    Based on a patch by Stanislav Manilov!
    chisophugis committed Mar 31, 2015
Commits on Mar 17, 2015
  1. [docs] Fix some malformed links.

    Patch by Stanislav Manilov!
    chisophugis committed Mar 17, 2015
Commits on Feb 7, 2015
Commits on Feb 5, 2015
  1. Silence a warning.

    /Users/Sean/pg/llvm/tools/clang/lib/CodeGen/CGException.cpp:1871:23: warning: unused variable 'Finally' [-Wunused-variable]
      if (SEHFinallyStmt *Finally = S.getFinallyHandler()) {
                          ^
    1 warning generated.
    chisophugis committed Feb 5, 2015
  2. Fixup.

    Didn't see these calls in my release build locally when testing.
    chisophugis committed Feb 5, 2015
Commits on Feb 4, 2015
Commits on Jan 29, 2015
  1. Remove unused tokens in the ll lexer.

    Patch by Robin Eklind!
    chisophugis committed Jan 29, 2015
Commits on Jan 28, 2015
  1. Avoid testing for a particular choice of resource dir.

    Without this patch, this test was accidentally testing that
    CLANG_RESOURCE_DIR, CLANG_LIBDIR_SUFFIX, and CLANG_VERSION_STRING
    were set to a particular set of values.
    
    The test was also getting pretty hairy since it was attempting to craft
    a regular expression that covered "all" possible combinations of
    settings for these configure-time constants.
    
    Clean it up by directly capturing the resource directory in a FileCheck
    variable.
    chisophugis committed Jan 28, 2015
  2. [docs] Use slightly more proper .rst markup

    Again, I'd like to emphasize to everyone that this sort of markup change
    is *not* what you should be concerned about when writing docs. Focus on
    *content*.
    
    I applaud Chandler for focusing on the fantastic content of this new
    section!
    chisophugis committed Jan 28, 2015
Commits on Jan 27, 2015
  1. No longer SCE_PRIVATE ;)

    chisophugis committed Jan 27, 2015
Commits on Jan 16, 2015
  1. Fix some copypasta typos in asserts.

    Fixes PR22236
    
    Patch by Nicolas Brunie! <nicolas.brunie@kalray.eu>
    chisophugis committed Jan 16, 2015
Commits on Jan 7, 2015
  1. Test commit.

    Hopefully this one won't kill the git mirror...
    chisophugis committed Jan 7, 2015
  2. [LangRef] PR22118: Hyphen is allowed in IR identifiers.

    E.g. %-foo and %fo-o.
    
    Thanks to eagle-eyed reporter Tomas Brukner.
    chisophugis committed Jan 7, 2015
Commits on Nov 26, 2014
  1. Add a small "usage:" comment at the top of not.cpp

    Mostly pulled from Rafael's r185678 commit message.
    chisophugis committed Nov 26, 2014
Commits on Nov 5, 2014
Commits on Sep 6, 2014
Commits on Sep 2, 2014
  1. Nuke MCAnalysis.

    The code is buggy and barely tested. It is also mostly boilerplate.
    (This includes MCObjectDisassembler, which is the interface to that
    functionality)
    
    Following an IRC discussion with Jim Grosbach, it seems sensible to just
    nuke the whole lot of functionality, and dig it up from VCS if
    necessary (I hope not!).
    
    All of this stuff appears to have been added in a huge patch dump (look
    at the timeframe surrounding e.g. r182628) where almost every patch
    seemed to be untested and not reviewed before being committed.
    Post-review responses to the patches were never addressed. I don't think
    any of it would have passed pre-commit review.
    
    I doubt anyone is depending on this, since this code appears to be
    extremely buggy. In limited testing that Michael Spencer and I did, we
    couldn't find a single real-world object file that wouldn't crash the
    CFG reconstruction stuff. The symbolizer stuff has O(n^2) behavior and
    so is not much use to anyone anyway. It seemed simpler to remove them as
    a whole. Most of this code is boilerplate, which is the only way it was
    able to scrape by 60% coverage.
    
    HEADSUP: Modules folks, some files I nuked were referenced from
    include/llvm/module.modulemap; I just deleted the references. Hopefully
    that is the right fix (one was a FIXME though!).
    chisophugis committed Sep 2, 2014
Commits on Aug 15, 2014
  1. Revert "Update for LLVM change (StringSaver)"

    This reverts commit r215785 / 170ebf4f19459ae51a9561d0e65c87ee4c9b2c97.
    
    LLD has some StringSavers that need to be updated. One of which takes a
    lock and I need to investigate that more closely.
    chisophugis committed Aug 15, 2014
  2. Revert "[Support] Promote cl::StringSaver to a separate utility"

    This reverts commit r215784 / 3f8a26f6fe16cc76c98ab21db2c600bd7defbbaa.
    
    LLD has 3 StringSaver's, one of which takes a lock when saving the
    string... Need to investigate more closely.
    chisophugis committed Aug 15, 2014
  3. Update for LLVM change (StringSaver)

    There is more cleanup to be done here. Once
    llvm::sys::Process::GetArgumentVector is switched over to StringSaver,
    we can simplify this code a fair amount.
    chisophugis committed Aug 15, 2014
  4. [Support] Promote cl::StringSaver to a separate utility

    This class is generally useful.
    
    In breaking it out, the primary change is that it has been made
    non-virtual. It seems like being abstract led to there being 3 different
    (2 in llvm + 1 in clang) concrete implementations which disagreed about
    the ownership of the saved strings (see the manual call to free() in the
    unittest StrDupSaver; yes this is different from the CommandLine.cpp
    StrDupSaver which owns the stored strings; which is different from
    Clang's StringSetSaver which just holds a reference to a
    std::set<std::string> which owns the strings).
    
    I've identified 2 other places in the
    codebase that are open-coding this pattern:
    
      memcpy(Alloc.Allocate<char>(strlen(S)+1), S, strlen(S)+1)
    
    I'll be switching them over. They are
    * llvm::sys::Process::GetArgumentVector
    * The StringAllocator member of YAMLIO's Input class
    This also will allow simplifying Clang's driver.cpp quite a bit.
    
    Let me know if there are any other places that could benefit from
    StringSaver. I'm also thinking of adding a saveStringRef member for
    getting a stable StringRef.
    chisophugis committed Aug 15, 2014
  5. ArrayRef'ize

    I've shied away from ArrayRef'izing CompilerInvocation::CreateFromArgs
    in this commit because that is a less localized change.
    chisophugis committed Aug 15, 2014
  6. Rename this function to better reflect its purpose

    Thanks to dblaikie for the impetus to look for a better name.
    chisophugis committed Aug 15, 2014
  7. [cleanup] Rename this function to better reflect its purpose. NFC.

    This also suggests some refactoring to simplify this code. Basically, a
    ton of complexity in this argument handling code comes from the need to
    save const char *'s in stable storage for pushing onto argv.
    It seems like llvm:🆑:StringSaver can be improved to cover all the
    needs here.
    chisophugis committed Aug 15, 2014
  8. [cleanup] Factor out some checks. NFC.

    The core logic in main() is actually pretty simple, but there's lots of
    stuff that has been added over time which obscures the flow of the code.
    In upcoming patches, I'll be pulling more stuff out of the main
    codepath.
    
    I'm open to naming suggestions for these helper functions.
    chisophugis committed Aug 15, 2014
Commits on Jul 1, 2014
  1. [docs] Fix a mangled sentence.

    Fixes PR20169
    chisophugis committed Jul 1, 2014