Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for buildPython versions 3.5 and 3.6 #713

Closed
mhsmith opened this issue Sep 20, 2022 · 2 comments
Closed

Remove support for buildPython versions 3.5 and 3.6 #713

mhsmith opened this issue Sep 20, 2022 · 2 comments
Milestone

Comments

@mhsmith
Copy link
Member

mhsmith commented Sep 20, 2022

See product/gradle-plugin/README.md for checklist.

3.5 was desupported by:

  • CPython in 2020-09
  • pip in 2021-01
  • Debian in 2022-06

3.6 was desupported by:

  • CPython in 2021-12
  • pip in 2022-01
  • It was never included in a stable version of Debian.
@mhsmith mhsmith changed the title Remove support for buildPython version 3.5 Remove support for buildPython versions 3.5 and 3.6 Sep 20, 2022
@mhsmith
Copy link
Member Author

mhsmith commented Sep 20, 2022

Once we no longer support 3.5, the special case for execResult.exitValue == 103 can be removed from PythonPlugin.execBuildPython, and test_py_not_found can changed to expect the message printed by the launcher itself, or perhaps simply removed.

@mhsmith
Copy link
Member Author

mhsmith commented Dec 25, 2022

Enabling PEP 517 (#715) required us to backport pip's vendored copy of tomli in order to support TOML 1.0 syntax. But this version of tomli contains type annotations on local variables, which were added in Python 3.6. So we need to desupport 3.5, and we might as well remove 3.6 at the same time.

@mhsmith mhsmith added this to the 13.1 milestone Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant