New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added getRotation() and test #34

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@dorianfm
Copy link

dorianfm commented Jun 2, 2017

I've added an FFmpegMovie->getRotation() method and test to return the rotation, or 0, of the movie file. This is particularly useful when dealing with movies that have been recorded portrait on mobile phones and where the width and height parameters should be transposed for presentation.

I've not changed the values returned from getFrameWidth() and getFrameHeight() when the getRotation() values is 90 or -90, though this should possible be discussed in future, it would be a breaking change to the API.

@char0n

This comment has been minimized.

Copy link
Owner

char0n commented Jun 2, 2017

@dorianfm thanks for your contribution. We are currently working on PSR-4-develop branch which will be next major release so I will port this PR to that branch. Master is freezed and we will not be adding anything new at this point.

@dorianfm

This comment has been minimized.

Copy link

dorianfm commented Jun 2, 2017

@char0n

This comment has been minimized.

Copy link
Owner

char0n commented Aug 23, 2017

@dorianfm I have incorporated your PR into the PSR-4-develop branch. Fixed some typos and formatting.... Unfortunately I had to handpick the changes and the trace that you contributed the code will be lost. Are you ok with that, if now what can I do to make it right ?

Thank you very much for your contribution.

@dorianfm

This comment has been minimized.

Copy link

dorianfm commented Aug 23, 2017

thanks @char0n, happy for it to be incorporated in any way, the availability of the functionality is much more important than any trace that I did it.

@char0n

This comment has been minimized.

Copy link
Owner

char0n commented Aug 23, 2017

@dorianfm ok cool. We have now new and shiny PSR-4 compatible codebase ready with full composer support. The only thing blocking the new release now are some infrastructure issues and writing a new documentation.

Thanks again.

@char0n char0n closed this Aug 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment