Remove shebang and executable bit from chardet/cli/chardetect.py #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
approved these changes
Jul 31, 2019
The CLI entry point is installed by setuptools through the console_scripts option. This setuptools feature automatically constructs a file with a shebang and sets the executable bit. The imported file chardet.cli.chardetect doesn't also require this bit.
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI entry point is installed by setuptools through the
console_scriptsoption. This setuptools feature automatically constructs a file with a shebang and sets the executable bit. The imported filechardet.cli.chardetectdoesn't also require this bit.