Skip to content

Commit

Permalink
Merge branch 'master' into rails3
Browse files Browse the repository at this point in the history
  • Loading branch information
shayfrendt committed Jun 21, 2012
2 parents 0d3252a + 5a4e9d1 commit e6de79a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion lib/acts_as_revisable/acts/common.rb
Expand Up @@ -57,7 +57,7 @@ def execute_after(key, &block) #:nodoc:
def branch(*args, &block) def branch(*args, &block)
is_branching! is_branching!


unless run_callbacks(:before_branch) { |r, o| r == false} unless run_callbacks(:before_branch)
raise ActiveRecord::RecordNotSaved raise ActiveRecord::RecordNotSaved
end end


Expand Down
4 changes: 2 additions & 2 deletions lib/acts_as_revisable/acts/deletable.rb
Expand Up @@ -23,11 +23,11 @@ def destroy


self.revisable_revised_at = self.revisable_deleted_at self.revisable_revised_at = self.revisable_deleted_at


return false unless run_callbacks(:before_revise_on_destroy) { |r, o| r == false} return false unless run_callbacks(:before_revise_on_destroy)
returning(self.save(:without_revision => true)) do returning(self.save(:without_revision => true)) do
run_callbacks(:after_revise_on_destroy) run_callbacks(:after_revise_on_destroy)
end end
end end
end end
end end
end end
8 changes: 4 additions & 4 deletions lib/acts_as_revisable/acts/revisable.rb
Expand Up @@ -107,7 +107,7 @@ def find_revision(by)
def revert_to(what, *args, &block) #:yields: def revert_to(what, *args, &block) #:yields:
is_reverting! is_reverting!


unless run_callbacks(:before_revert) { |r, o| r == false} unless run_callbacks(:before_revert)
raise ActiveRecord::RecordNotSaved raise ActiveRecord::RecordNotSaved
end end


Expand All @@ -116,7 +116,7 @@ def revert_to(what, *args, &block) #:yields:
rev = find_revision(what) rev = find_revision(what)
self.reverting_to, self.reverting_from = rev, self self.reverting_to, self.reverting_from = rev, self


unless rev.run_callbacks(:before_restore) { |r, o| r == false} unless rev.run_callbacks(:before_restore)
raise ActiveRecord::RecordNotSaved raise ActiveRecord::RecordNotSaved
end end


Expand Down Expand Up @@ -240,7 +240,7 @@ def changeset(&block)


return yield(self) if in_revision? return yield(self) if in_revision?


unless run_callbacks(:before_changeset) { |r, o| r == false} unless run_callbacks(:before_changeset)
raise ActiveRecord::RecordNotSaved raise ActiveRecord::RecordNotSaved
end end


Expand Down Expand Up @@ -314,7 +314,7 @@ def before_revisable_update #:nodoc:
return unless should_revise? return unless should_revise?
in_revision! in_revision!


unless run_callbacks(:before_revise) { |r, o| r == false} unless run_callbacks(:before_revise)
in_revision!(false) in_revision!(false)
return false return false
end end
Expand Down

0 comments on commit e6de79a

Please sign in to comment.