Added hosted_page_url and hosted_update_payment_page_url methods to Subscription #65

Closed
wants to merge 5 commits into from

4 participants

@ryan0x44

These changes will allow you to generate the hosted "update_payment" page URLs from a Subscription instance. It generates the URL with a 10 character SHA1 token as per documentation: http://docs.chargify.com/hosted-page-integration#hosted-page-urls

@chase439

Cool, I added similar capabilities to mine at chase439/chargify_api_ares@2306105

@ryan0x44

@chase439 nice! would be great to have this functionality in the official gem :)

@jeremywrowe jeremywrowe commented on the diff Aug 19, 2014
lib/chargify_api_ares/resources/subscription.rb
@@ -62,6 +78,14 @@ def migrate(attrs = {})
post :migrations, :migration => attrs
end
+ def migrate_preview(attrs = {})

We have added this functionality in commit 598298d. Would you mind removing migration_preview and so that we can go with the implementation that already exists?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@jeremywrowe

@ryandjurovich Looks great. Can you please add some tests and make the suggested updates?

@desmondhume

Is anybody going to merge this?
It would be great to have this feature in the gem
👍

@jeremywrowe

@desmondhume it needs to be brought up to date with master and the changes need to be made first, I will gladly consider it then :)

@jeremywrowe

I am going to close this until there is a response, please feel free to reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment