Skip to content
Permalink
Branch: master
Commits on Mar 27, 2019
  1. Fix #15 and add a test to avoid regression

    charignon committed Mar 27, 2019
  2. Fix #14

    charignon committed Mar 27, 2019
  3. Update README.md

    charignon committed Mar 27, 2019
    Fix typo in `forge`
Commits on Mar 16, 2019
  1. Merge pull request #13 from charignon/lc--add-hook-to-review-forge-prs

    charignon committed Mar 16, 2019
    [Fix #11] Make it possible to review forge PRs
Commits on Mar 10, 2019
  1. [Fix #11] Make it possible to review forge PRs

    charignon committed Mar 9, 2019
  2. Merge pull request #10 from charignon/lc--add-top-level-comments-by-o…

    charignon committed Mar 10, 2019
    …thers
    
    Show top level comments and reviews
  3. #### Summary

    charignon committed Mar 4, 2019
    Before this PR when using `github-review` one can download PRs title, body and diff and insert top level and inline comments.
    After this PR, one can get more information when performing a review, including, reviews from other people, inline comments and issues top-level comments (made by replying to a PR). It also opens future work to support reply to inline comments (#9)
    
    It looks like this:
    ```diff
    ~ PR TITLE
    ~
    ~ PR body
    ~ on multiple line
    ~ @foo: a comment at the top level
    ~ Reviewed by @Babar[APPROVED]: LGTM (a review comment)
    <actual diff>
    ```
    
    #### Progress
    This is really rough work in progress, docstrings aren't final and this isn't fully tested.
    - [X] Top level, issue comments
    - [X] Reviews state and summary
    - [ ] Inline comments (moved to another Change)
    
    #### Test Plan
    - [X] Add testing to start-review for new types of comments
    - [X] Test end to end with multiple scenarios
    
    This will enable adding new functionality like showing previous inline
    and top level comments.
Commits on Mar 7, 2019
  1. Merge pull request #8 from charignon/lc--add-melpa-instructions

    charignon committed Mar 7, 2019
    [Readme] add installation instructions
Commits on Mar 3, 2019
  1. [Readme] add installation instructions

    charignon committed Mar 3, 2019
  2. Merge pull request #6 from charignon/lc--handle-deleted-files

    charignon committed Mar 3, 2019
    [Fix #4] Handle deleted files correctly
  3. Merge branch 'master' into lc--handle-deleted-files

    charignon committed Mar 3, 2019
  4. Merge pull request #7 from charignon/lc--add-ci

    charignon committed Mar 3, 2019
    [Dev] Add CI
  5. Add CI with circle CI

    charignon committed Mar 3, 2019
Commits on Feb 24, 2019
  1. Update to match another round of review on melpa/melpa#6020

    charignon committed Feb 24, 2019
Commits on Feb 23, 2019
  1. Rename url to repo

    charignon committed Feb 23, 2019
  2. Define github token scope

    charignon committed Feb 23, 2019
    This allows people to create token with the ghub token creation flow.
Commits on Feb 20, 2019
  1. Improve documentation

    charignon committed Feb 20, 2019
  2. Improve documentation

    charignon committed Feb 20, 2019
Commits on Feb 18, 2019
  1. Update README.md

    charignon committed Feb 18, 2019
Commits on Feb 17, 2019
  1. Fix indentation mismatch

    charignon committed Feb 17, 2019
  2. Capitalize GitHub properly

    charignon committed Feb 17, 2019
  3. Update commentary

    charignon committed Feb 17, 2019
Commits on Feb 12, 2019
  1. Change title

    charignon committed Feb 12, 2019
  2. Update readme

    charignon committed Feb 12, 2019
Commits on Feb 11, 2019
  1. Fix issue with callbacks

    charignon committed Feb 11, 2019
  2. Update doc in makefile

    charignon committed Feb 11, 2019
  3. Add docstring for constant

    charignon committed Feb 11, 2019
Older
You can’t perform that action at this time.