Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for P1144/P2786 trivial relocatability #1

Merged

Conversation

Quuxplusone
Copy link
Contributor

@charles-salvia charles-salvia merged commit 4197481 into charles-salvia:master Nov 9, 2023
@Quuxplusone
Copy link
Contributor Author

@charles-salvia: Actually, I think now I spoke too soon. You've got this:

// -------- specialization for is_trivially_relocatable
//
template <class Y, class G, class D, class P>
struct is_trivially_relocatable<intrusive_ptr<Y,G,D,P>> : std::true_type
{ };

which doesn't work with a P1144-enabled standard library (because you're not allowed to specialize standard type traits). But I also don't yet understand why you need to specialize this for intrusive_ptr, along your pre-P1144 codepath — who's checking the value of this type-trait? I need to look deeper at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants