From 952573f389447eb0357a5370d2899b163886b946 Mon Sep 17 00:00:00 2001 From: charles7668 Date: Thu, 29 Feb 2024 10:47:37 +0800 Subject: [PATCH] Fix issue link does not support quotes (#29484) --- modules/references/references.go | 2 +- modules/references/references_test.go | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/modules/references/references.go b/modules/references/references.go index 7758312564508..6809162af2d91 100644 --- a/modules/references/references.go +++ b/modules/references/references.go @@ -33,7 +33,7 @@ var ( // issueNumericPattern matches string that references to a numeric issue, e.g. #1287 issueNumericPattern = regexp.MustCompile(`(?:\s|^|\(|\[|\')([#!][0-9]+)(?:\s|$|\)|\]|[:;,.?!]\s|[:;,.?!]$)`) // issueAlphanumericPattern matches string that references to an alphanumeric issue, e.g. ABC-1234 - issueAlphanumericPattern = regexp.MustCompile(`(?:\s|^|\(|\[)([A-Z]{1,10}-[1-9][0-9]*)(?:\s|$|\)|\]|:|\.(\s|$))`) + issueAlphanumericPattern = regexp.MustCompile(`(?:\s|^|\(|\[|\"|\')([A-Z]{1,10}-[1-9][0-9]*)(?:\s|$|\)|\]|:|\.(\s|$)|\"|\')`) // crossReferenceIssueNumericPattern matches string that references a numeric issue in a different repository // e.g. org/repo#12345 crossReferenceIssueNumericPattern = regexp.MustCompile(`(?:\s|^|\(|\[)([0-9a-zA-Z-_\.]+/[0-9a-zA-Z-_\.]+[#!][0-9]+)(?:\s|$|\)|\]|[:;,.?!]\s|[:;,.?!]$)`) diff --git a/modules/references/references_test.go b/modules/references/references_test.go index ba7dda80ccf9c..7b0e0078be921 100644 --- a/modules/references/references_test.go +++ b/modules/references/references_test.go @@ -459,6 +459,8 @@ func TestRegExp_issueAlphanumericPattern(t *testing.T) { "(ABC-123)", "[ABC-123]", "ABC-123:", + "\"ABC-123\"", + "'ABC-123'", } falseTestCases := []string{ "RC-08",