Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatch between south and east cases #1

Open
wants to merge 1 commit into
base: acm_challenge
Choose a base branch
from

Conversation

Xom
Copy link

@Xom Xom commented Jul 10, 2023

I discovered this bug after porting your code to GDScript for my game jam game A Bag Deal: https://jamiehello.itch.io/a-bag-deal

This change is a backport to Java. I have not run or tested this Java version, though the change seems straightforward to me.

The bug had caused Player 1 to play EEQUITES in the following screenshot: https://cdn.discordapp.com/attachments/218820487105478657/1127713889115717762/image.png
It happened before Player 2 played RIFLEMAN. EQUITES was already on the board. Player 1's rack was VOIOEII. The word list was CSW22 (279077 words). Note that the bonus placements and tile values are nonstandard.

Xom added a commit to jamie-hello/game-by-jamie-and-xom that referenced this pull request Jul 10, 2023
@Xom
Copy link
Author

Xom commented Jul 10, 2023

Actually I think your code might not play EEQUITES anyway, because in my version, I removed some checks from isValidMove() which seemed redundant to me in the circumstances in which it is called, but which might prevent EEQUITES from being played in your version. Separately, my version never had the wrong version of line 270, which seems to me like it may cause some valid moves not to be considered in your version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant