New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email checking with regex does not work #116

Closed
Fizzadar opened this Issue Mar 6, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@Fizzadar
Contributor

Fizzadar commented Mar 6, 2017

The check_email function raises the ValueError for valid emails. Ultimately I believe there's no point doing any checking on email (except for the mere existence of @), because regex is simply not up to it.

eg:

check_email('åliå@test.com')
>>> raises ValueError
@stephenross

This comment has been minimized.

Show comment
Hide comment
@stephenross

stephenross Mar 6, 2017

Collaborator
Collaborator

stephenross commented Mar 6, 2017

@charlesthk charlesthk closed this in #117 Mar 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment