Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement flake8-simplify SIM105 rule #1621

merged 4 commits into from Jan 4, 2023


Copy link

@messense messense commented Jan 4, 2023

Ref #998

Copy link
Contributor Author

messense commented Jan 4, 2023

Not sure how to implement autofix and proper error span yet, still learning😅

handler_names.join(", ")
let check = Check::new(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a hard one to autofix right now because it depends on contextlib being imported already.

@messense messense marked this pull request as ready for review January 4, 2023 05:17
Copy link

Thank you!

@charliermarsh charliermarsh merged commit 0df28bd into charliermarsh:main Jan 4, 2023
5 of 6 checks passed
@messense messense deleted the flake8-simplify-sim105 branch January 4, 2023 13:13
renovate bot added a commit to ixm-one/pytest-cmake-presets that referenced this pull request Jan 5, 2023

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
| [ruff]( | `^0.0.210` ->
`^0.0.211` |


### Release Notes




#### What's Changed

- Implement `SIM220` and `SIM221` by
[@&#8203;charliermarsh]( in
- Implement flake8-simplify SIM105 rule by
[@&#8203;messense]( in
- Fix `SIM105` by [@&#8203;harupy]( in
- Adding my company to the "used in" category of the Readme. by
[@&#8203;colin99d]( in
- Implement flake8-bandit rule `S103` by
[@&#8203;edgarrmondragon]( in
- Rename flake8-bandit rules from plugins to checks by
[@&#8203;charliermarsh]( in
- Tweak Yoda condition message by
[@&#8203;charliermarsh]( in
- Note a few more incompatibilities by
[@&#8203;charliermarsh]( in
- Add task-tags & ignore-overlong-task-comments settings by
[@&#8203;not-my-profile]( in
- Add badge JSON by
[@&#8203;charliermarsh]( in
- Add Ruff badge to README by
[@&#8203;charliermarsh]( in
- DRY up unused import removal code by
[@&#8203;charliermarsh]( in
- Implement builtin import removal by
[@&#8203;charliermarsh]( in
- Move external licenses to separate directory by
[@&#8203;charliermarsh]( in
- Implement nested-if detection by
[@&#8203;charliermarsh]( in
- Implement flake8-bandit rule `S108` by
[@&#8203;edgarrmondragon]( in
- Implement nested with detection (SIM117) by
[@&#8203;charliermarsh]( in
- Cancel outdated in-progress workflow automatically by
[@&#8203;messense]( in
- Implement flake8-simplify SIM107 by
[@&#8203;messense]( in
- Implement `SIM110` and `SIM111` (conversion to `any` and `all`) by
[@&#8203;charliermarsh]( in

**Full Changelog**:



### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

 **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update


- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box


This PR has been generated by [Mend
Renovate]( View
repository job log


Signed-off-by: Renovate Bot <>
Co-authored-by: renovate[bot] <29139614+renovate[bot]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants