New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proc-macro to derive CheckCodePrefix
#1656
Add proc-macro to derive CheckCodePrefix
#1656
Conversation
f9aabe7
to
9180834
Compare
9180834
to
465ed69
Compare
Yeah this makes a lot of sense, thank you. My main critique of macros like this is that they hurt the IDE experience, since (e.g.) |
(Nice work.) |
Autocompletion works fine for me using rust-analyzer, which has |
I think intellij-rust also works fine with derive macros now: intellij-rust/intellij-rust#6908
|
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.211` -> `^0.0.212` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.212`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.212) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.211...v0.0.212) #### What's Changed - Add task-tags & ignore-overlong-task-comments settings by [@​charliermarsh](https://togithub.com/charliermarsh) in [charliermarsh/ruff#1654 - Stop highlighting --help output in README as shell by [@​not-my-profile](https://togithub.com/not-my-profile) in [charliermarsh/ruff#1655 - Add proc-macro to derive `CheckCodePrefix` by [@​messense](https://togithub.com/messense) in [charliermarsh/ruff#1656 - \[`flake8-bandit`] Add Rule for `S324` (Insecure hash functions in `hashlib`) by [@​saadmk11](https://togithub.com/saadmk11) in [charliermarsh/ruff#1661 - Avoid false-positives for yields with non-identical references by [@​charliermarsh](https://togithub.com/charliermarsh) in [charliermarsh/ruff#1665 - \[`flake8-bandit`] Add Rule for `S506` (unsafe use of yaml load) by [@​saadmk11](https://togithub.com/saadmk11) in [charliermarsh/ruff#1664 - Fix flake8-import-conventions configuration examples by [@​diego-pm](https://togithub.com/diego-pm) in [charliermarsh/ruff#1660 - Allow overhang in Google-style docstring arguments by [@​charliermarsh](https://togithub.com/charliermarsh) in [charliermarsh/ruff#1668 - Fix some `&String`, `&Option`, and `&Vec` usages by [@​charliermarsh](https://togithub.com/charliermarsh) in [charliermarsh/ruff#1670 - Improve Pandas call and attribute detection by [@​charliermarsh](https://togithub.com/charliermarsh) in [charliermarsh/ruff#1671 - Implement duplicate isinstance detection (SIM101) by [@​charliermarsh](https://togithub.com/charliermarsh) in [charliermarsh/ruff#1673 - Replace \&String with \&str in AnnotatedImport::ImportFrom by [@​andersk](https://togithub.com/andersk) in [charliermarsh/ruff#1674 - Simplify Option<String> → Option<\&str> conversion using as_deref by [@​andersk](https://togithub.com/andersk) in [charliermarsh/ruff#1675 - Remove an unneeded .to_string() in tokenize_files_to_codes_mapping by [@​andersk](https://togithub.com/andersk) in [charliermarsh/ruff#1676 #### New Contributors - [@​diego-pm](https://togithub.com/diego-pm) made their first contribution in [charliermarsh/ruff#1660 **Full Changelog**: charliermarsh/ruff@v0.0.211...v0.0.212 </details> --- ### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC44MS4wIiwidXBkYXRlZEluVmVyIjoiMzQuODEuMCJ9--> Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
IMO a derive macro is a natural way to generate new code, and it reduces the chance of merge conflicts.