Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Pandas call and attribute detection #1671

merged 1 commit into from Jan 6, 2023


Copy link

This PR adds some guardrails to avoid common false positives in our pandas-vet rules. Specifically, we now avoid triggering pandas-vet rules if the target of the call or attribute (i.e., the x in x.stack(...)) is unbound, or bound to something that couldn't be a DataFrame (like an import that isn't pandas, or a class definition). This lets us avoid common false positives like np.stack(...).

Resolves #1659.

@charliermarsh charliermarsh merged commit 04111da into main Jan 6, 2023
4 checks passed
@charliermarsh charliermarsh deleted the charlie/pd branch January 6, 2023 00:30
renovate bot added a commit to ixm-one/pytest-cmake-presets that referenced this pull request Jan 6, 2023

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
| [ruff]( | `^0.0.211` ->
`^0.0.212` |


### Release Notes




#### What's Changed

- Add task-tags & ignore-overlong-task-comments settings by
[@&#8203;charliermarsh]( in
- Stop highlighting --help output in README as shell by
[@&#8203;not-my-profile]( in
- Add proc-macro to derive `CheckCodePrefix` by
[@&#8203;messense]( in
- \[`flake8-bandit`] Add Rule for `S324` (Insecure hash functions in
`hashlib`) by [@&#8203;saadmk11]( in
- Avoid false-positives for yields with non-identical references by
[@&#8203;charliermarsh]( in
- \[`flake8-bandit`] Add Rule for `S506` (unsafe use of yaml load) by
[@&#8203;saadmk11]( in
- Fix flake8-import-conventions configuration examples by
[@&#8203;diego-pm]( in
- Allow overhang in Google-style docstring arguments by
[@&#8203;charliermarsh]( in
- Fix some `&String`, `&Option`, and `&Vec` usages by
[@&#8203;charliermarsh]( in
- Improve Pandas call and attribute detection by
[@&#8203;charliermarsh]( in
- Implement duplicate isinstance detection (SIM101) by
[@&#8203;charliermarsh]( in
- Replace \&String with \&str in AnnotatedImport::ImportFrom by
[@&#8203;andersk]( in
- Simplify Option<String> → Option<\&str> conversion using as_deref by
[@&#8203;andersk]( in
- Remove an unneeded .to_string() in tokenize_files_to_codes_mapping by
[@&#8203;andersk]( in

#### New Contributors

- [@&#8203;diego-pm]( made their first
contribution in

**Full Changelog**:



### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

 **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update


- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box


This PR has been generated by [Mend
Renovate]( View
repository job log


Signed-off-by: Renovate Bot <>
Co-authored-by: renovate[bot] <29139614+renovate[bot]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

PD013 UseOfDotStack triggered by np.stack
1 participant