Improve Pandas call and attribute detection #1671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR adds some guardrails to avoid common false positives in our
pandas-vet
rules. Specifically, we now avoid triggeringpandas-vet
rules if the target of the call or attribute (i.e., thex
inx.stack(...)
) is unbound, or bound to something that couldn't be a DataFrame (like an import that isn'tpandas
, or a class definition). This lets us avoid common false positives likenp.stack(...)
.Resolves #1659.