A way to configure what ip's are 'local' #99

Closed
glebtv opened this Issue Jan 25, 2013 · 13 comments

9 participants

@glebtv

With commit 2446965 it is no longer possible to use better_errors remotely.

This is a problem when you, for example, use Win desktop + a Linux virtualbox for development, or any other kind of setup like that. And there seems to be no way to add some IP's to trusted/local.

@jinyk

As use of Vagrant for development gets more popular, this is a crucial feature I think.

@ericboehs

Agreed. I'm having this issue as well. It shouldn't be hard coded to local IPs only.

@ericboehs

Until this is added either reference my github repo or use this monkey patch: https://gist.github.com/ericboehs/4735037

@toobulkeh

ericboehs: thanks for the monkey patch!

@rking

A one-off monkeypatch is where this feature belongs.

Please at least use an IP whitelist if you're going to actually do this in the gem.

@rschmitty

Monkey patch not working for me @ericboehs anything else I should do?

edit: nm, just set everything to true for now, looking forward to this being fix in main gem

@burabure

took me a while to figure out why it wasn't working on my setup (pretty common, Windows + ubuntu server VM)
Thanks a lot for the Module patch but we really need a proper config option.

@rking

Can you try + 👍 or 👎 #130 please?

@glebtv

Please, at least allow whitelisting with a mask like 192.168.1.*

@rking
@rschmitty

CIDR notation works for me 👍 thanks @rking

@charliesome
Owner

Resolved by #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment