Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade RSpec #365

Merged
merged 2 commits into from Jul 29, 2017
Merged

Upgrade RSpec #365

merged 2 commits into from Jul 29, 2017

Conversation

bquorning
Copy link
Contributor

@bquorning bquorning commented Mar 23, 2017

As an alternative to #364, we can upgrade to use a newer version of RSpec. This should fix fixes the build on Travis.

This conversion is done by Transpec 3.3.0 with the following command:
    transpec

* 91 conversions
    from: obj.should
      to: expect(obj).to

* 57 conversions
    from: == expected
      to: eq(expected)

* 18 conversions
    from: obj.stub(:message)
      to: allow(obj).to receive(:message)

* 10 conversions
    from: obj.should_not
      to: expect(obj).not_to

* 6 conversions
    from: obj.should_receive(:message)
      to: expect(obj).to receive(:message)

* 3 conversions
    from: =~ /pattern/
      to: match(/pattern/)

* 2 conversions
    from: obj.should_not_receive(:message)
      to: expect(obj).not_to receive(:message)

For more details: https://github.com/yujinakayama/transpec#supported-conversions
@bquorning
Copy link
Contributor Author

cc/ @charliesome

RobinDaugherty added a commit to RobinDaugherty/better_errors that referenced this pull request Jul 9, 2017
@RobinDaugherty RobinDaugherty merged commit 45ad7cc into BetterErrors:master Jul 29, 2017
@RobinDaugherty
Copy link
Member

Thanks for the PR @bquorning!

@RobinDaugherty RobinDaugherty added this to the v2.2 milestone Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants