diff --git a/cmd/soft/root.go b/cmd/soft/root.go index 6a536f228..e8317dd88 100644 --- a/cmd/soft/root.go +++ b/cmd/soft/root.go @@ -1,9 +1,9 @@ package main import ( - "log" "runtime/debug" + "github.com/charmbracelet/log" "github.com/spf13/cobra" ) @@ -49,6 +49,6 @@ func init() { func main() { if err := rootCmd.Execute(); err != nil { - log.Fatalln(err) + log.Fatal(err) } } diff --git a/cmd/soft/serve.go b/cmd/soft/serve.go index 58c1f43c6..5b0b49787 100644 --- a/cmd/soft/serve.go +++ b/cmd/soft/serve.go @@ -2,12 +2,14 @@ package main import ( "context" - "log" + "fmt" "os" "os/signal" "syscall" "time" + "github.com/charmbracelet/log" + "github.com/charmbracelet/soft-serve/server" "github.com/charmbracelet/soft-serve/server/config" "github.com/spf13/cobra" @@ -23,7 +25,7 @@ var ( cfg := config.DefaultConfig() s := server.NewServer(cfg) - log.Printf("Starting SSH server on %s:%d", cfg.BindAddr, cfg.Port) + log.Print("Starting SSH server", "addr", fmt.Sprintf("%s:%d", cfg.BindAddr, cfg.Port)) done := make(chan os.Signal, 1) lch := make(chan error, 1) @@ -36,7 +38,7 @@ var ( signal.Notify(done, os.Interrupt, syscall.SIGINT, syscall.SIGTERM) <-done - log.Printf("Stopping SSH server on %s:%d", cfg.BindAddr, cfg.Port) + log.Print("Stopping SSH server", "addr", fmt.Sprintf("%s:%d", cfg.BindAddr, cfg.Port)) ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second) defer cancel() if err := s.Shutdown(ctx); err != nil { diff --git a/config/auth.go b/config/auth.go index 30e8d6719..84da840f4 100644 --- a/config/auth.go +++ b/config/auth.go @@ -1,9 +1,10 @@ package config import ( - "log" "strings" + "github.com/charmbracelet/log" + gm "github.com/charmbracelet/wish/git" "github.com/gliderlabs/ssh" gossh "golang.org/x/crypto/ssh" @@ -14,19 +15,19 @@ func (cfg *Config) Push(repo string, pk ssh.PublicKey) { go func() { err := cfg.Reload() if err != nil { - log.Printf("error reloading after push: %s", err) + log.Error("error reloading after push", "err", err) } if cfg.Cfg.Callbacks != nil { cfg.Cfg.Callbacks.Push(repo) } r, err := cfg.Source.GetRepo(repo) if err != nil { - log.Printf("error getting repo after push: %s", err) + log.Error("error getting repo after push", "err", err) return } err = r.UpdateServerInfo() if err != nil { - log.Printf("error updating server info after push: %s", err) + log.Error("error updating server info after push", "err", err) } }() } @@ -88,7 +89,7 @@ func (cfg *Config) accessForKey(repo string, pk ssh.PublicKey) gm.AccessLevel { for _, k := range user.PublicKeys { apk, _, _, _, err := ssh.ParseAuthorizedKey([]byte(strings.TrimSpace(k))) if err != nil { - log.Printf("error: malformed authorized key: '%s'", k) + log.Error("malformed authorized key", "key", k) return gm.NoAccess } if ssh.KeysEqual(pk, apk) { diff --git a/config/config.go b/config/config.go index 7046a52b7..27e083d6c 100644 --- a/config/config.go +++ b/config/config.go @@ -5,13 +5,14 @@ import ( "encoding/json" "errors" "io/fs" - "log" "path/filepath" "strings" "sync" "text/template" "time" + "github.com/charmbracelet/log" + "golang.org/x/crypto/ssh" "gopkg.in/yaml.v3" @@ -192,7 +193,7 @@ func (cfg *Config) Reload() error { } if err := cfg.readConfig(repo, &rc); err != nil { if !errors.Is(err, ErrNoConfig) { - log.Printf("error reading config: %v", err) + log.Error("error reading config", "err", err) } continue } @@ -208,7 +209,7 @@ func (cfg *Config) Reload() error { repo := r.Repo() err = r.UpdateServerInfo() if err != nil { - log.Printf("error updating server info for %s: %s", repo, err) + log.Error("error updating server info", "repo", repo, "err", err) } pat := "README*" rp := "" diff --git a/config/git.go b/config/git.go index d1d4d6a3d..9c36f1895 100644 --- a/config/git.go +++ b/config/git.go @@ -2,11 +2,12 @@ package config import ( "errors" - "log" "os" "path/filepath" "sync" + "github.com/charmbracelet/log" + "github.com/charmbracelet/soft-serve/git" "github.com/gobwas/glob" "github.com/golang/groupcache/lru" @@ -239,7 +240,7 @@ func (rs *RepoSource) LoadRepo(name string) error { rp := filepath.Join(rs.Path, name) r, err := rs.open(rp) if err != nil { - log.Printf("error opening repository %q: %s", rp, err) + log.Error("error opening repository", "path", rp, "err", err) return err } rs.repos[name] = r @@ -254,7 +255,7 @@ func (rs *RepoSource) LoadRepos() error { } for _, de := range rd { if !de.IsDir() { - log.Printf("warning: %q is not a directory", filepath.Join(rs.Path, de.Name())) + log.Warn("not a directory", "path", filepath.Join(rs.Path, de.Name())) continue } err = rs.LoadRepo(de.Name()) diff --git a/examples/setuid/main.go b/examples/setuid/main.go index 0c58fbb83..4a722eb9b 100644 --- a/examples/setuid/main.go +++ b/examples/setuid/main.go @@ -11,13 +11,14 @@ import ( "context" "flag" "fmt" - "log" "net" "os" "os/signal" "syscall" "time" + "github.com/charmbracelet/log" + "github.com/charmbracelet/soft-serve/server" "github.com/charmbracelet/soft-serve/server/config" ) @@ -34,14 +35,14 @@ func main() { // To listen on port 22 we need root privileges ls, err := net.Listen("tcp", addr) if err != nil { - log.Fatalf("Can't listen: %s", err) + log.Fatal("Can't listen", "err", err) } // We don't need root privileges any more if err := syscall.Setgid(*gid); err != nil { - log.Fatalf("Setgid error: %s", err) + log.Fatal("Setgid error", "err", err) } if err := syscall.Setuid(*uid); err != nil { - log.Fatalf("Setuid error: %s", err) + log.Fatal("Setuid error", "err", err) } cfg := config.DefaultConfig() cfg.Port = *port @@ -50,19 +51,19 @@ func main() { done := make(chan os.Signal, 1) signal.Notify(done, os.Interrupt, syscall.SIGINT, syscall.SIGTERM) - log.Printf("Starting SSH server on %s:%d", cfg.BindAddr, cfg.Port) + log.Print("Starting SSH server", "addr", fmt.Sprintf("%s:%d", cfg.BindAddr, cfg.Port)) go func() { if err := s.Serve(ls); err != nil { - log.Fatalln(err) + log.Fatal(err) } }() <-done - log.Printf("Stopping SSH server on %s:%d", cfg.BindAddr, cfg.Port) + log.Print("Stopping SSH server", fmt.Sprintf("%s:%d", cfg.BindAddr, cfg.Port)) ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second) defer func() { cancel() }() if err := s.Shutdown(ctx); err != nil { - log.Fatalln(err) + log.Fatal(err) } } diff --git a/go.mod b/go.mod index af4443f1c..7b2cabca1 100644 --- a/go.mod +++ b/go.mod @@ -6,7 +6,7 @@ require ( github.com/alecthomas/chroma v0.10.0 github.com/caarlos0/env/v6 v6.10.1 github.com/charmbracelet/bubbles v0.14.0 - github.com/charmbracelet/bubbletea v0.23.1 + github.com/charmbracelet/bubbletea v0.23.2 github.com/charmbracelet/glamour v0.5.1-0.20221015050842-c4cd9ed13e4c github.com/charmbracelet/lipgloss v0.6.0 github.com/charmbracelet/wish v0.7.0 @@ -16,14 +16,15 @@ require ( github.com/go-git/go-git/v5 v5.4.2 github.com/matryer/is v1.4.0 github.com/muesli/reflow v0.3.0 - github.com/muesli/termenv v0.13.0 + github.com/muesli/termenv v0.14.0 github.com/sergi/go-diff v1.1.0 - golang.org/x/crypto v0.0.0-20220826181053-bd7e27e6170d + golang.org/x/crypto v0.6.0 ) require ( github.com/aymanbagabas/go-osc52 v1.2.1 github.com/charmbracelet/keygen v0.3.0 + github.com/charmbracelet/log v0.1.0 github.com/gobwas/glob v0.2.3 github.com/gogs/git-module v1.7.1 github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da @@ -46,13 +47,14 @@ require ( github.com/dlclark/regexp2 v1.4.0 // indirect github.com/emirpasic/gods v1.12.0 // indirect github.com/go-git/gcfg v1.5.0 // indirect + github.com/go-logfmt/logfmt v0.6.0 // indirect github.com/gorilla/css v1.0.0 // indirect github.com/imdario/mergo v0.3.12 // indirect github.com/inconshreveable/mousetrap v1.0.1 // indirect github.com/jbenet/go-context v0.0.0-20150711004518-d14ea06fba99 // indirect github.com/kevinburke/ssh_config v1.1.0 // indirect github.com/lucasb-eyer/go-colorful v1.2.0 // indirect - github.com/mattn/go-isatty v0.0.16 // indirect + github.com/mattn/go-isatty v0.0.17 // indirect github.com/mattn/go-localereader v0.0.1 // indirect github.com/mattn/go-runewidth v0.0.14 // indirect github.com/mcuadros/go-version v0.0.0-20190308113854-92cdf37c5b75 // indirect @@ -69,10 +71,11 @@ require ( github.com/xanzy/ssh-agent v0.3.1 // indirect github.com/yuin/goldmark v1.5.2 // indirect github.com/yuin/goldmark-emoji v1.0.1 // indirect - golang.org/x/net v0.0.0-20221002022538-bcab6841153b // indirect - golang.org/x/sys v0.3.0 // indirect - golang.org/x/term v0.0.0-20220722155259-a9ba230a4035 // indirect - golang.org/x/text v0.3.7 // indirect + golang.org/x/net v0.7.0 // indirect + golang.org/x/sync v0.1.0 // indirect + golang.org/x/sys v0.5.0 // indirect + golang.org/x/term v0.5.0 // indirect + golang.org/x/text v0.7.0 // indirect gopkg.in/warnings.v0 v0.1.2 // indirect gopkg.in/yaml.v2 v2.4.0 // indirect ) diff --git a/go.sum b/go.sum index 9e8448d80..3cce3ffe4 100644 --- a/go.sum +++ b/go.sum @@ -33,6 +33,8 @@ github.com/charmbracelet/bubbletea v0.21.0/go.mod h1:GgmJMec61d08zXsOhqRC/AiOx4K github.com/charmbracelet/bubbletea v0.22.0/go.mod h1:aoVIwlNlr5wbCB26KhxfrqAn0bMp4YpJcoOelbxApjs= github.com/charmbracelet/bubbletea v0.23.1 h1:CYdteX1wCiCzKNUlwm25ZHBIc1GXlYFyUIte8WPvhck= github.com/charmbracelet/bubbletea v0.23.1/go.mod h1:JAfGK/3/pPKHTnAS8JIE2u9f61BjWTQY57RbT25aMXU= +github.com/charmbracelet/bubbletea v0.23.2 h1:vuUJ9HJ7b/COy4I30e8xDVQ+VRDUEFykIjryPfgsdps= +github.com/charmbracelet/bubbletea v0.23.2/go.mod h1:FaP3WUivcTM0xOKNmhciz60M6I+weYLF76mr1JyI7sM= github.com/charmbracelet/glamour v0.5.1-0.20221015050842-c4cd9ed13e4c h1:ab5qQmotMEJBf9OfZxqGfoIEkFpiPZp7Wt6oSwAWa1c= github.com/charmbracelet/glamour v0.5.1-0.20221015050842-c4cd9ed13e4c/go.mod h1:taqWV4swIMMbWALc0m7AfE9JkPSU8om2538k9ITBxOc= github.com/charmbracelet/harmonica v0.2.0/go.mod h1:KSri/1RMQOZLbw7AHqgcBycp8pgJnQMYYT8QZRqZ1Ao= @@ -41,6 +43,8 @@ github.com/charmbracelet/keygen v0.3.0/go.mod h1:1ukgO8806O25lUZ5s0IrNur+RlwTBER github.com/charmbracelet/lipgloss v0.5.0/go.mod h1:EZLha/HbzEt7cYqdFPovlqy5FZPj0xFhg5SaqxScmgs= github.com/charmbracelet/lipgloss v0.6.0 h1:1StyZB9vBSOyuZxQUcUwGr17JmojPNm87inij9N3wJY= github.com/charmbracelet/lipgloss v0.6.0/go.mod h1:tHh2wr34xcHjC2HCXIlGSG1jaDF0S0atAUvBMP6Ppuk= +github.com/charmbracelet/log v0.1.0 h1:NZLLgBgfohpn78LWAkEEMSiI2RE3RaG/41kcd/qAcpo= +github.com/charmbracelet/log v0.1.0/go.mod h1:nbG+jJlMwbPM8v2wFyPG6qCr9flLQ1XTS+fhzUWd6JE= github.com/charmbracelet/wish v0.7.0 h1:rdfacCWaKCQpCMPbOKfi68GYqsb+9CnUzN1Ov/INZJ0= github.com/charmbracelet/wish v0.7.0/go.mod h1:16EQz7k3hEgPkPENghcpEddvlrmucIudE0jnczKr+k4= github.com/containerd/console v1.0.3 h1:lIr7SlA5PxZyMV30bDW0MGbiOPXwc63yRuCP0ARubLw= @@ -70,6 +74,8 @@ github.com/go-git/go-git-fixtures/v4 v4.2.1 h1:n9gGL1Ct/yIw+nfsfr8s4+sbhT+Ncu2Su github.com/go-git/go-git-fixtures/v4 v4.2.1/go.mod h1:K8zd3kDUAykwTdDCr+I0per6Y6vMiRR/nnVTBtavnB0= github.com/go-git/go-git/v5 v5.4.2 h1:BXyZu9t0VkbiHtqrsvdq39UDhGJTl1h55VW6CSC4aY4= github.com/go-git/go-git/v5 v5.4.2/go.mod h1:gQ1kArt6d+n+BGd+/B/I74HwRTLhth2+zti4ihgckDc= +github.com/go-logfmt/logfmt v0.6.0 h1:wGYYu3uicYdqXVgoYbvnkrPVXkuLM1p1ifugDMEdRi4= +github.com/go-logfmt/logfmt v0.6.0/go.mod h1:WYhtIu8zTZfxdn5+rREduYbwxfcBr/Vr6KEVveWlfTs= github.com/gobwas/glob v0.2.3 h1:A4xDbljILXROh+kObIiy5kIaPYD8e96x1tgBhUI5J+Y= github.com/gobwas/glob v0.2.3/go.mod h1:d3Ez4x06l9bZtSvzIay5+Yzi0fmZzPgnTbPcKjJAkT8= github.com/gogs/git-module v1.7.1 h1:KzK3oZ9YMVV6HyWxStFTTcFpCKsFRb8424qKTpa59XM= @@ -111,8 +117,9 @@ github.com/matryer/is v1.2.0/go.mod h1:2fLPjFQM9rhQ15aVEtbuwhJinnOqrmgXPNdZsdwlW github.com/matryer/is v1.4.0 h1:sosSmIWwkYITGrxZ25ULNDeKiMNzFSr4V/eqBQP0PeE= github.com/matryer/is v1.4.0/go.mod h1:8I/i5uYgLzgsgEloJE1U6xx5HkBQpAZvepWuujKwMRU= github.com/mattn/go-isatty v0.0.14/go.mod h1:7GGIvUiUoEMVVmxf/4nioHXj79iQHKdU27kJ6hsGG94= -github.com/mattn/go-isatty v0.0.16 h1:bq3VjFmv/sOjHtdEhmkEV4x1AJtvUvOJ2PFAZ5+peKQ= github.com/mattn/go-isatty v0.0.16/go.mod h1:kYGgaQfpe5nmfYZH+SKPsOc2e4SrIfOl2e/yFXSvRLM= +github.com/mattn/go-isatty v0.0.17 h1:BTarxUcIeDqL27Mc+vyvdWYSL28zpIhv3RoTdsLMPng= +github.com/mattn/go-isatty v0.0.17/go.mod h1:kYGgaQfpe5nmfYZH+SKPsOc2e4SrIfOl2e/yFXSvRLM= github.com/mattn/go-localereader v0.0.1 h1:ygSAOl7ZXTx4RdPYinUpg6W99U8jWvWi9Ye2JC/oIi4= github.com/mattn/go-localereader v0.0.1/go.mod h1:8fBrzywKY7BI3czFoHkuzRoWE9C+EiG4R1k4Cjx5p88= github.com/mattn/go-runewidth v0.0.9/go.mod h1:H031xJmbD/WCDINGzjvQ9THkh0rPKHF+m2gUSrubnMI= @@ -149,6 +156,8 @@ github.com/muesli/termenv v0.11.1-0.20220204035834-5ac8409525e0/go.mod h1:Bd5NYQ github.com/muesli/termenv v0.11.1-0.20220212125758-44cd13922739/go.mod h1:Bd5NYQ7pd+SrtBSrSNoBBmXlcY8+Xj4BMJgh8qcZrvs= github.com/muesli/termenv v0.13.0 h1:wK20DRpJdDX8b7Ek2QfhvqhRQFZ237RGRO0RQ/Iqdy0= github.com/muesli/termenv v0.13.0/go.mod h1:sP1+uffeLaEYpyOTb8pLCUctGcGLnoFjSn4YJK5e2bc= +github.com/muesli/termenv v0.14.0 h1:8x9NFfOe8lmIWK4pgy3IfVEy47f+ppe3tUqdPZG2Uy0= +github.com/muesli/termenv v0.14.0/go.mod h1:kG/pF1E7fh949Xhe156crRUrHNyK221IuGO7Ez60Uc8= github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e/go.mod h1:zD1mROLANZcx1PVRCS0qkT7pwLkGfwJo4zjcN/Tysno= github.com/olekukonko/tablewriter v0.0.5 h1:P2Ga83D34wi1o9J6Wh1mRuqd4mF/x/lgBS7N7AbDhec= github.com/olekukonko/tablewriter v0.0.5/go.mod h1:hPp6KlRPjbx+hW8ykQs1w3UBbZlj6HuIJcUGPhkA7kY= @@ -198,15 +207,22 @@ golang.org/x/crypto v0.0.0-20210711020723-a769d52b0f97/go.mod h1:GvvjBRRGRdwPK5y golang.org/x/crypto v0.0.0-20220307211146-efcb8507fb70/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4= golang.org/x/crypto v0.0.0-20220826181053-bd7e27e6170d h1:3qF+Z8Hkrw9sOhrFHti9TlB1Hkac1x+DNRkv0XQiFjo= golang.org/x/crypto v0.0.0-20220826181053-bd7e27e6170d/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4= +golang.org/x/crypto v0.6.0 h1:qfktjS5LUO+fFKeJXZ+ikTRijMmljikvG68fpMMruSc= +golang.org/x/crypto v0.6.0/go.mod h1:OFC/31mSvZgRz0V1QTNCzfAI1aIRzbiufJtkMIlEp58= golang.org/x/net v0.0.0-20210226172049-e18ecbb05110/go.mod h1:m0MpNAwzfU5UDzcl9v0D8zg8gWTRqZa9RBIspLL5mdg= golang.org/x/net v0.0.0-20210326060303-6b1517762897/go.mod h1:uSPa2vr4CLtc/ILN5odXGNXS6mhrKVzTaCXzk9m6W3k= golang.org/x/net v0.0.0-20211112202133-69e39bad7dc2/go.mod h1:9nx3DQGgdP8bBQD5qxJ1jj9UTztislL4KSBs9R2vV5Y= golang.org/x/net v0.0.0-20220826154423-83b083e8dc8b/go.mod h1:YDH+HFinaLZZlnHAfSS6ZXJJ9M9t4Dl22yv3iI2vPwk= golang.org/x/net v0.0.0-20221002022538-bcab6841153b h1:6e93nYa3hNqAvLr0pD4PN1fFS+gKzp2zAXqrnTCstqU= golang.org/x/net v0.0.0-20221002022538-bcab6841153b/go.mod h1:YDH+HFinaLZZlnHAfSS6ZXJJ9M9t4Dl22yv3iI2vPwk= +golang.org/x/net v0.6.0/go.mod h1:2Tu9+aMcznHK/AK1HMvgo6xiTLG5rD5rZLDS+rp2Bjs= +golang.org/x/net v0.7.0 h1:rJrUqqhjsgNp7KqAIc25s9pZnjU7TUcSY7HcVZjdn1g= +golang.org/x/net v0.7.0/go.mod h1:2Tu9+aMcznHK/AK1HMvgo6xiTLG5rD5rZLDS+rp2Bjs= golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= golang.org/x/sync v0.0.0-20210220032951-036812b2e83c h1:5KslGYwFpkhGh+Q16bwMP3cOontH8FOep7tGV86Y7SQ= golang.org/x/sync v0.0.0-20210220032951-036812b2e83c/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= +golang.org/x/sync v0.1.0 h1:wsuoTGHzEhffawBOhz5CYhcrV4IdKZbEyZjBMuTp12o= +golang.org/x/sync v0.1.0/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= golang.org/x/sys v0.0.0-20180905080454-ebe1bf3edb33/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= golang.org/x/sys v0.0.0-20190507160741-ecd444e8653b/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= golang.org/x/sys v0.0.0-20190916202348-b4ddaad3f8a3/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs= @@ -228,14 +244,20 @@ golang.org/x/sys v0.0.0-20220811171246-fbc7d0a398ab/go.mod h1:oPkhp1MJrh7nUepCBc golang.org/x/sys v0.0.0-20220825204002-c680a09ffe64/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.3.0 h1:w8ZOecv6NaNa/zC8944JTU3vz4u6Lagfk4RPQxv92NQ= golang.org/x/sys v0.3.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= +golang.org/x/sys v0.5.0 h1:MUK/U/4lj1t1oPg0HfuXDN/Z1wv31ZJ/YcPiGccS4DU= +golang.org/x/sys v0.5.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo= golang.org/x/term v0.0.0-20210927222741-03fcf44c2211/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8= golang.org/x/term v0.0.0-20220722155259-a9ba230a4035 h1:Q5284mrmYTpACcm+eAKjKJH48BBwSyfJqmmGDTtT8Vc= golang.org/x/term v0.0.0-20220722155259-a9ba230a4035/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8= +golang.org/x/term v0.5.0 h1:n2a8QNdAb0sZNpU9R1ALUXBbY+w51fCQDN+7EdxNBsY= +golang.org/x/term v0.5.0/go.mod h1:jMB1sMXY+tzblOD4FWmEbocvup2/aLOaQEp7JmGp78k= golang.org/x/text v0.3.3/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ= golang.org/x/text v0.3.6/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ= golang.org/x/text v0.3.7 h1:olpwvP2KacW1ZWvsR7uQhoyTYvKAupfQrRGBFM352Gk= golang.org/x/text v0.3.7/go.mod h1:u+2+/6zg+i71rQMx5EYifcz6MCKuco9NR6JIITiCfzQ= +golang.org/x/text v0.7.0 h1:4BRB4x83lYWy72KwLD/qYDuTu7q9PjSagHvijDw7cLo= +golang.org/x/text v0.7.0/go.mod h1:mrYo+phRRbMaCq/xk9113O4dZlRixOauAjOtrjsXDZ8= golang.org/x/time v0.0.0-20220411224347-583f2d630306/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ= golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ= golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0= diff --git a/server/config/config.go b/server/config/config.go index dc60e2dad..79cc867f4 100644 --- a/server/config/config.go +++ b/server/config/config.go @@ -1,10 +1,11 @@ package config import ( - "log" + glog "log" "path/filepath" "github.com/caarlos0/env/v6" + "github.com/charmbracelet/log" ) // Callbacks provides an interface that can be used to run callbacks on different events. @@ -21,17 +22,21 @@ type Config struct { Port int `env:"SOFT_SERVE_PORT" envDefault:"23231"` KeyPath string `env:"SOFT_SERVE_KEY_PATH"` RepoPath string `env:"SOFT_SERVE_REPO_PATH" envDefault:".repos"` + Debug bool `env:"SOFT_SERVE_DEBUG" envDefault:"false"` InitialAdminKeys []string `env:"SOFT_SERVE_INITIAL_ADMIN_KEY" envSeparator:"\n"` Callbacks Callbacks - ErrorLog *log.Logger + ErrorLog *glog.Logger } // DefaultConfig returns a Config with the values populated with the defaults // or specified environment variables. func DefaultConfig() *Config { - cfg := &Config{ErrorLog: log.Default()} + cfg := &Config{ErrorLog: log.StandardLog(log.StandardLogOption{ForceLevel: log.ErrorLevel})} if err := env.Parse(cfg); err != nil { - log.Fatalln(err) + log.Fatal(err) + } + if cfg.Debug { + log.SetLevel(log.DebugLevel) } if cfg.KeyPath == "" { // NB: cross-platform-compatible path @@ -47,7 +52,7 @@ func (c *Config) WithCallbacks(callbacks Callbacks) *Config { } // WithErrorLogger sets the error logger for the configuration. -func (c *Config) WithErrorLogger(logger *log.Logger) *Config { +func (c *Config) WithErrorLogger(logger *glog.Logger) *Config { c.ErrorLog = logger return c } diff --git a/server/server.go b/server/server.go index c651776f1..9ee3dc1f3 100644 --- a/server/server.go +++ b/server/server.go @@ -3,11 +3,12 @@ package server import ( "context" "fmt" - "log" "net" "path/filepath" "strings" + "github.com/charmbracelet/log" + appCfg "github.com/charmbracelet/soft-serve/config" "github.com/charmbracelet/soft-serve/server/config" "github.com/charmbracelet/wish" @@ -63,7 +64,7 @@ func NewServer(cfg *config.Config) *Server { sh(s) } }, - lm.Middleware(), + lm.MiddlewareWithLogger(log.StandardLog(log.StandardLogOption{ForceLevel: log.DebugLevel})), ), } s, err := wish.NewServer( @@ -74,7 +75,7 @@ func NewServer(cfg *config.Config) *Server { wish.WithMiddleware(mw...), ) if err != nil { - log.Fatalln(err) + log.Fatal(err) } return &Server{ SSHServer: s, diff --git a/server/session_test.go b/server/session_test.go index 3257be89c..324402e65 100644 --- a/server/session_test.go +++ b/server/session_test.go @@ -40,15 +40,15 @@ func TestSession(t *testing.T) { defer s.Close() err := s.RequestPty("xterm", 80, 40, nil) is.NoErr(err) + in, err := s.StdinPipe() + is.NoErr(err) go func() { - time.Sleep(1 * time.Second) - s.Signal(gossh.SIGTERM) - // FIXME: exit with code 0 instead of forcibly closing the session - s.Close() + <-time.After(time.Second) + // Send "q" to exit the config command + in.Write([]byte("q")) }() - err = s.Run("test") - var ee *gossh.ExitMissingError - is.True(errors.As(err, &ee)) + err = s.Shell() + is.NoErr(err) }) }