update overlays to reference 1.24/stable charms #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
commented
May 5, 2022
addyess
commented
May 5, 2022
overlays/ceph-fs.yaml
Outdated
| @@ -10,12 +10,12 @@ applications: | |||
| osd-devices: '32G,2' | |||
| osd-journals: '8G,1' | |||
| ceph-mon: | |||
| charm: ceph-mon | |||
| charm: cs:ceph-mon | |||
There was a problem hiding this comment.
just got it with the revert--- i'm going back and fixing.
evilnick
reviewed
May 5, 2022
evilnick
reviewed
May 5, 2022
kwmonroe
reviewed
May 5, 2022
overlays/equinix-overlay.yaml
Outdated
Comment on lines
131
to
132
| - - 'kubernetes-control-plane:ceph-storage' | ||
| - 'ceph-mon:admin' |
There was a problem hiding this comment.
Suggested change
| - - 'kubernetes-control-plane:ceph-storage' | |
| - 'ceph-mon:admin' |
We dropped the ceph-storage relation in charmed-kubernetes/charm-kubernetes-control-plane#219
Co-authored-by: Kevin W Monroe <kevin.monroe@canonical.com>
kwmonroe
approved these changes
May 5, 2022
kwmonroe
added a commit
that referenced
this pull request
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.