Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some extra information into ldap page for dashboard and kubectl. #149

Merged
merged 3 commits into from Apr 9, 2019

Conversation

3 participants
@hyperbolic2346
Copy link
Contributor

hyperbolic2346 commented Apr 8, 2019

Added another image.

Also, moved some things from ## to ###. Not sure if that is desired, but they all seemed related.

I'm not married to any of the format changes, feel free to alter as you see fit.

Hopefully fixes #147

Adding some extra information into ldap page for dashboard and kubectl.
Added another image.

Also, moved some things from ## to ###. Not sure if that is desired, but they all seemed related.

I'm not married to any of the format changes, feel free to alter as you see fit.

@hyperbolic2346 hyperbolic2346 requested a review from evilnick Apr 8, 2019

@tvansteenburgh
Copy link
Contributor

tvansteenburgh left a comment

LGTM, thanks!

@evilnick I'd like to get this published soonish - Field requested this addition.

evilnick added some commits Apr 9, 2019

@evilnick
Copy link
Collaborator

evilnick left a comment

🍺

@evilnick evilnick merged commit 8219c88 into master Apr 9, 2019

@hyperbolic2346 hyperbolic2346 deleted the mwilson/ldap-cleanup branch Apr 9, 2019

@evilnick evilnick referenced this pull request Apr 9, 2019

Merged

Backport #149 to current #151

evilnick added a commit that referenced this pull request Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.