Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s/canonical-kubernetes/charmed-kubernetes #158

Merged
merged 2 commits into from Apr 16, 2019

Conversation

2 participants
@evilnick
Copy link
Collaborator

evilnick commented Apr 15, 2019

it was a little more complicated than that...

@tvansteenburgh
Copy link
Contributor

tvansteenburgh left a comment

LGTM, with one suggestion.

@@ -296,3 +294,4 @@ things you may wish to try:
[logging]: /kubernetes/docs/logging
[decommission]: /kubernetes/docs/decommissioning
[get-in-touch]: /kubernetes/docs/get-in-touch
[bundle-source]: https://api.jujucharms.com/charmstore/v5/charmed-kubernetes-3/archive/bundle.yaml?channel=stable

This comment has been minimized.

Copy link
@tvansteenburgh

tvansteenburgh Apr 15, 2019

Contributor

Maybe change this to https://api.jujucharms.com/charmstore/v5/charmed-kubernetes/archive/bundle.yaml?channel=stable instead (remove the revision number) so it always points to latest stable.

This comment has been minimized.

Copy link
@evilnick

evilnick Apr 15, 2019

Author Collaborator

yes, that's a good plan, thanks!

@evilnick evilnick merged commit 05923a1 into charmed-kubernetes:master Apr 16, 2019

1 check passed

netlify/cdk-docs-next/deploy-preview Deploy preview ready!
Details

@evilnick evilnick referenced this pull request Apr 18, 2019

Merged

Backport #158 to current #162

evilnick added a commit that referenced this pull request Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.