Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kata Containers docs #257

Merged
merged 15 commits into from Sep 5, 2019

Conversation

@joedborg
Copy link
Contributor

commented Aug 26, 2019

Need to add this to the sidebar, but I can find "shared/_side-navigation.md".

@joedborg joedborg requested review from evilnick and tvansteenburgh Aug 26, 2019

@joedborg joedborg self-assigned this Aug 26, 2019

@joedborg

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

joedborg added 3 commits Aug 27, 2019

@joedborg joedborg marked this pull request as ready for review Aug 27, 2019

@joedborg joedborg referenced this pull request Aug 27, 2019
@tvansteenburgh
Copy link
Contributor

left a comment

Thanks @joedborg - left some feedback for your consideration.

pages/k8s/untrusted-container-runtime.md Outdated Show resolved Hide resolved
pages/k8s/untrusted-container-runtime.md Outdated Show resolved Hide resolved
pages/k8s/untrusted-container-runtime.md Outdated Show resolved Hide resolved
pages/k8s/untrusted-container-runtime.md Outdated Show resolved Hide resolved
pages/k8s/untrusted-container-runtime.md Outdated Show resolved Hide resolved
pages/k8s/untrusted-container-runtime.md Outdated Show resolved Hide resolved

@joedborg joedborg requested a review from tvansteenburgh Aug 28, 2019

joedborg and others added 4 commits Aug 28, 2019
@tvansteenburgh
Copy link
Contributor

left a comment

LGTM but I'll let @evilnick have a look before merging.

tvansteenburgh and others added 6 commits Aug 29, 2019
@evilnick
Copy link
Collaborator

left a comment

🍰

@evilnick evilnick merged commit 662efe9 into master Sep 5, 2019

3 of 5 checks passed

Header rules - cdk-docs-next No header rules processed
Details
Pages changed - cdk-docs-next 58 new files uploaded
Details
Mixed content - cdk-docs-next No mixed content detected
Details
Redirect rules - cdk-docs-next 3 redirect rules processed
Details
netlify/cdk-docs-next/deploy-preview Deploy preview ready!
Details

@evilnick evilnick deleted the kata-docs branch Sep 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.