From 4fc7704a8f57f71debe73c00f009e78546ac9e65 Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Wed, 13 Feb 2019 16:05:44 -0800 Subject: [PATCH] nonNegativeOrDefault --- src/scales/scale.logarithmic.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/scales/scale.logarithmic.js b/src/scales/scale.logarithmic.js index 6911ed76062..a2fc3d7ee09 100644 --- a/src/scales/scale.logarithmic.js +++ b/src/scales/scale.logarithmic.js @@ -62,9 +62,9 @@ var defaultConfig = { } }; -// TODO(v3): change this to isPositive -function isNonNegative(value) { - return helpers.isFinite(value) && value >= 0; +// TODO(v3): change this to isPositiveOrDefault +function nonNegativeOrDefault(value, defaultValue) { + return helpers.isFinite(value) && value >= 0 ? value : defaultValue; } module.exports = Scale.extend({ @@ -179,8 +179,8 @@ module.exports = Scale.extend({ var DEFAULT_MIN = 1; var DEFAULT_MAX = 10; - me.min = isNonNegative(tickOpts.min) ? tickOpts.min : me.min; - me.max = isNonNegative(tickOpts.max) ? tickOpts.max : me.max; + me.min = nonNegativeOrDefault(tickOpts.min, me.min); + me.max = nonNegativeOrDefault(tickOpts.max, me.max); if (me.min === me.max) { if (me.min !== 0 && me.min !== null) { @@ -216,8 +216,8 @@ module.exports = Scale.extend({ var reverse = !me.isHorizontal(); var generationOptions = { - min: isNonNegative(tickOpts.min) ? tickOpts.min : undefined, - max: isNonNegative(tickOpts.max) ? tickOpts.max : undefined + min: nonNegativeOrDefault(tickOpts.min), + max: nonNegativeOrDefault(tickOpts.max) }; var ticks = me.ticks = generateTicks(generationOptions, me);