From e208bb927f884bff429a3347b819f50026ba80b8 Mon Sep 17 00:00:00 2001 From: Jukka Kurkela Date: Wed, 8 Jan 2020 14:05:50 +0200 Subject: [PATCH] Skip NaN --- src/scales/scale.logarithmic.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/scales/scale.logarithmic.js b/src/scales/scale.logarithmic.js index ef6f8837f56..7cf63ad1320 100644 --- a/src/scales/scale.logarithmic.js +++ b/src/scales/scale.logarithmic.js @@ -62,6 +62,9 @@ const defaultConfig = { class LogarithmicScale extends Scale { _parse(raw, index) { // eslint-disable-line no-unused-vars const value = LinearScaleBase.prototype._parse.apply(this, arguments); + if (value === 0) { + return null; + } return isFinite(value) && value > 0 ? value : NaN; } @@ -133,7 +136,7 @@ class LogarithmicScale extends Scale { } getLabelForValue(value) { - return value || 0; + return value === null ? 0 : value; } getPixelForTick(index) { @@ -156,7 +159,10 @@ class LogarithmicScale extends Scale { getPixelForValue(value) { const me = this; - return me.getPixelForDecimal((log10(value || me.min) - me._startValue) / me._valueRange); + if (value === null) { + value = me.min; + } + return me.getPixelForDecimal(log10(value - me._startValue) / me._valueRange); } getValueForPixel(pixel) {