Fix : Scale label display at top and right. #3741
Conversation
1.Rotation of scale label when scale is right. 2.Scale position at rotation when scale is top.
etimberg
left a comment
etimberg
left a comment
There was a problem hiding this comment.
Other than my comment on the vertical label, I think this looks good. Not sure if there is a way to write a test for this or not
src/core/core.scale.js
Outdated
| scaleLabelX = isLeft ? me.left + (scaleLabelFont.size / 2) : me.right - (scaleLabelFont.size / 2); | ||
| scaleLabelY = me.top + ((me.bottom - me.top) / 2); | ||
| rotation = isLeft ? -0.5 * Math.PI : 0.5 * Math.PI; | ||
| rotation = -0.5 * Math.PI; |
There was a problem hiding this comment.
I'm not sure about this change. I, personally, find it easier to read in the current orientation on the right side. CC @chartjs/maintainers thoughts?
There was a problem hiding this comment.
Please compare these two examples.
I think that the second figure is easier to read when I look at the four scale labels.
Because It is a personal opinion, I think that it is OK to cancel this change.
There was a problem hiding this comment.
It's also consistent with the label on the left.
There was a problem hiding this comment.
The reason I wrote it the current way is that to me it felt more natural to turn my head to the right on the right side and to the left on the left side.
I don't know what most chart packages do though. If everyone else has the proposed rotation then we can change it.
There was a problem hiding this comment.
I think that the old version is better, and the labels should have their bottom along the side of the chart.
There was a problem hiding this comment.
Thank you for considering it. I will cancel this change.
Fix Scale position at rotation when scale is top.
5 participants
The following problem was solved.
1.Rotation of scale label when scale is right
2.Scale position at rotation when scale is top.
Before
jsFiddle
After
jsFiddle