Flatten animation object and fix callbacks #3959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Animation callbacks now receives `animationObject` directly with a reference on the associated chart (`animation.chart`), which deprecates `animation.animationObject` and `animation.chartInstance`. Also fix missing `onComplete` animation argument and make sure that an animation object is passed even when animations are disabled.
etimberg
approved these changes
Feb 25, 2017
Member
etimberg
left a comment
etimberg
left a comment
There was a problem hiding this comment.
I thinks this looks good. I was going to comment that animationObject and chartInstance weren't maintained, but then I got to the Object.defineProperty calls at the end. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Animation callbacks now receives
animationObjectdirectly with a reference on the associated chart (animation.chart), which deprecatesanimation.animationObjectandanimation.chartInstance. Also fix missingonCompleteanimation argument and update documentation aboutonCompletecalled withanimation: nullif animation is disabled.Fixes #3781 #3911