Add support to fill between datasets #4008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
force-pushed
the
filler-plugin
branch
from
c1da740 to
25d9b43
Compare
etimberg
approved these changes
Mar 11, 2017
Member
etimberg
left a comment
etimberg
left a comment
There was a problem hiding this comment.
Code looks good. Will build and test this out now
etimberg
reviewed
Mar 11, 2017
| if (this.rand() <= continuity) { | ||
| data.push(Math.round(dfactor * value) / dfactor); | ||
| } else { | ||
| data.push(null); |
Member
There was a problem hiding this comment.
In testing this was causing problems because the lines weren't actually skipping null data. If I change this to NaN the skipping works as expected.
Member
There was a problem hiding this comment.
This null vs NaN issue only affects the radar chart. The regular line chart seems to work fine
Member
Author
There was a problem hiding this comment.
null seems a more natural way to skip point so I would rather fix the radar chart to behave like the line one. What do you think?
Member
Author
There was a problem hiding this comment.
I think the issue comes from here (not sure why you kept null in this change)
Member
There was a problem hiding this comment.
Agreed, I think the radar chart should behave like the line. Not sure why I left null there either
etimberg
reviewed
Mar 11, 2017
| <link rel="stylesheet" type="text/css" href="../style.css"> | ||
| <script src="../../dist/Chart.bundle.js"></script> | ||
| <script src="../utils.js"></script> | ||
| <script src="analyser.js"></script> |
Member
There was a problem hiding this comment.
I'm not seeing any output in the code section for both samples. Is that expected?
Member
Author
There was a problem hiding this comment.
Good catch, it should be fixed now :) (used _filler instead of $filler)
simonbrunel
force-pushed
the
filler-plugin
branch
from
25d9b43 to
2b92152
Compare
panzarino
approved these changes
Mar 11, 2017
etimberg
approved these changes
Mar 11, 2017
simonbrunel
force-pushed
the
filler-plugin
branch
from
2b92152 to
fe31f88
Compare
The `fill` option now accepts the index of the target dataset (number) or a string starting by "+" or "-" followed by a number representing the dataset index relative to the current one (e.g. `fill: "-2"` on dataset at index 3 will fill to dataset at index 1). It's also possible to "propagate" the filling to the target of an hidden dataset (`options.plugins.filler.propagate`). Fill boundaries `zero`, `top` and `bottom` have been deprecated and replaced by `origin`, `start` and `end`. Implementation has been moved out of the line element into a new plugin (`src/plugins/plugin.filler.js`) and does not rely anymore on the deprecated model `scaleTop`, `scaleBottom` and `scaleZero` values. Drawing Bézier splines has been refactored in the canvas helpers (note that `Chart.helpers.canvas` is now an alias of `Chart.canvasHelpers`). Add 3 new examples and extend utils with a pseudo-random number generator that can be initialized with `srand`. That makes possible to design examples starting always with the same initial data.
simonbrunel
force-pushed
the
filler-plugin
branch
from
fe31f88 to
ed6af96
Compare
This was referenced Jun 12, 2017
roicos
pushed a commit
to roicos/Chart.js
that referenced
this pull request
Aug 21, 2017
The `fill` option now accepts the index of the target dataset (number) or a string starting by "+" or "-" followed by a number representing the dataset index relative to the current one (e.g. `fill: "-2"` on dataset at index 3 will fill to dataset at index 1). It's also possible to "propagate" the filling to the target of an hidden dataset (`options.plugins.filler.propagate`). Fill boundaries `zero`, `top` and `bottom` have been deprecated and replaced by `origin`, `start` and `end`. Implementation has been moved out of the line element into a new plugin (`src/plugins/plugin.filler.js`) and does not rely anymore on the deprecated model `scaleTop`, `scaleBottom` and `scaleZero` values. Drawing Bézier splines has been refactored in the canvas helpers (note that `Chart.helpers.canvas` is now an alias of `Chart.canvasHelpers`). Add 3 new examples and extend utils with a pseudo-random number generator that can be initialized with `srand`. That makes possible to design examples starting always with the same initial data.
|
Assuming that you have two datasets, when setting |
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
The `fill` option now accepts the index of the target dataset (number) or a string starting by "+" or "-" followed by a number representing the dataset index relative to the current one (e.g. `fill: "-2"` on dataset at index 3 will fill to dataset at index 1). It's also possible to "propagate" the filling to the target of an hidden dataset (`options.plugins.filler.propagate`). Fill boundaries `zero`, `top` and `bottom` have been deprecated and replaced by `origin`, `start` and `end`. Implementation has been moved out of the line element into a new plugin (`src/plugins/plugin.filler.js`) and does not rely anymore on the deprecated model `scaleTop`, `scaleBottom` and `scaleZero` values. Drawing Bézier splines has been refactored in the canvas helpers (note that `Chart.helpers.canvas` is now an alias of `Chart.canvasHelpers`). Add 3 new examples and extend utils with a pseudo-random number generator that can be initialized with `srand`. That makes possible to design examples starting always with the same initial data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
filloption now accepts the index of the target dataset (number) or a string starting by "+" or "-" followed by a number representing the dataset index relative to the current one (e.g.fill: "-2"on dataset at index 3 will fill to dataset at index 1). It's also possible to "propagate" the filling to the target of an hidden dataset (options.plugins.filler.propagate). Fill boundarieszero,topandbottomhave been deprecated and replaced byorigin,startandend.Implementation has been moved out of the line element into a new plugin (
src/plugins/plugin.filler.js) and does not rely anymore on the deprecated modelscaleTop,scaleBottomandscaleZerovalues. Drawing Bézier splines has been refactored in the canvas helpers (note thatChart.helpers.canvasis now an alias ofChart.canvasHelpers).Add 2 new examples (line and radar) and extend utils with a pseudo-random number generator that can be initialized with
srand. That makes possible to design examples starting always with the same initial data.Will submit another PR with documentation when #3751 is merged (let's keep #3547 as a reminder).
Fixes #2380 #2945
Demo