fix typos and broken links in the documents #5010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
requested changes
Nov 29, 2017
Member
simonbrunel
left a comment
simonbrunel
left a comment
There was a problem hiding this comment.
Looks really good, I would just rename the "Ratio" section to "Pixel Ratio"
docs/SUMMARY.md
Outdated
| * [Usage](getting-started/usage.md) | ||
| * [General](general/README.md) | ||
| * [Responsive](general/responsive.md) | ||
| * [Ratio](general/device-pixel-ratio.md) |
Member
There was a problem hiding this comment.
I would call this section "Pixel Ratio" since there is also "Aspect Ratio" detailed in the Responsive section
Respond to changes request
Contributor
Author
|
I renamed the "Ratio" section to "Pixel Ratio". Thank you for the quick reviews. 😄 |
simonbrunel
approved these changes
Nov 30, 2017
Member
|
Thanks @beiz23 |
yofreke
pushed a commit
to yofreke/Chart.js
that referenced
this pull request
Dec 30, 2017
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/general/device-pixel-ratio.mdindocs/SUMMARY.md, since users could not reach the document on device-pixel-ratio.