Optimization: prevent double ticks array reverse for logarithmic scale #5076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hmic axis
with ticks option 'reverse: true'.
simonbrunel
approved these changes
Dec 23, 2017
Member
simonbrunel
left a comment
simonbrunel
left a comment
There was a problem hiding this comment.
Looks good, thanks @jcopperfield
etimberg
approved these changes
Dec 23, 2017
yofreke
pushed a commit
to yofreke/Chart.js
that referenced
this pull request
Dec 30, 2017
…hmic axis (chartjs#5076) with ticks option 'reverse: true'.
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
…hmic axis (chartjs#5076) with ticks option 'reverse: true'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the logarithmic scale reverses the ticks for vertical axis and then checks if the axis is reverse and reverse it again.
The optimization sets the reverse flag for vertical axis and inverts the flag for the reverse ticks option, so that the reverse action is only applied once.