Skip to content

Stop limiting getDecimalForPixel to chart area #6608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2019
Merged

Stop limiting getDecimalForPixel to chart area #6608

merged 1 commit into from
Oct 27, 2019

Conversation

@kurkle
Copy link
Member

@kurkle kurkle commented Oct 27, 2019

Remove limits.

Fixes: chartjs/chartjs-plugin-zoom#279

benmccann
benmccann approved these changes Oct 27, 2019
View reviewed changes
Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faster too! ;-)

thanks for investigating and fixing the bug in the zoom plugin! And thanks @exwm for the tremendously good report and investigation!

@etimberg etimberg merged commit 11883aa into chartjs:master Oct 27, 2019
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
@kurkle kurkle deleted the pan branch November 13, 2019 06:11
@snyk-bot snyk-bot mentioned this pull request Nov 13, 2019
Merged
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
This was referenced Apr 1, 2020
Open
Open
This was referenced Apr 14, 2020
Open
Open
@martinakraus martinakraus mentioned this pull request Jun 5, 2024
Closed
@jaimeperez-vs jaimeperez-vs mentioned this pull request Jun 18, 2024
Open
This was referenced Aug 16, 2024
Open
Open
This was referenced Sep 8, 2024
Open
Open
@ryanmichaelfabayos ryanmichaelfabayos mentioned this pull request Sep 20, 2024
Open
@luisgarciaxygeni luisgarciaxygeni mentioned this pull request Sep 28, 2024
Open
@saadi1995 saadi1995 mentioned this pull request Oct 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etimberg etimberg etimberg approved these changes

+1 more reviewer

@benmccann benmccann benmccann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type: chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Panning Broken with Chart.js 2.9.0

3 participants

@kurkle @benmccann @etimberg