Skip to content

Stop mutating arc state while drawing #9153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 25, 2021
Merged

Stop mutating arc state while drawing #9153

merged 5 commits into from
May 25, 2021

Conversation

@kurkle
Copy link
Member

@kurkle kurkle commented May 25, 2021

Fix #9151

  • only consider full circles when circumference > TAU
  • pass the custom endAngle as argument instead of mutating state

@kurkle
Copy link
Member Author

kurkle commented May 25, 2021 •
edited
Loading

Filename Size Change
dist/chart.esm.js 70.4 kB +30 B (0%)
dist/chart.js 89.4 kB +30 B (0%)
dist/chart.min.js 63.7 kB +25 B (0%)

@kurkle kurkle requested a review from simonbrunel May 25, 2021 05:07
simonbrunel
simonbrunel previously approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

With these changes, do we still need the special case in #9152?

Did you check that it fixes the issue with the datalabels plugin?

@kurkle
Copy link
Member Author

kurkle commented May 25, 2021

Did you check that it fixes the issue with the datalabels plugin?

image

simonbrunel
simonbrunel approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@etimberg etimberg added this to the Version 3.3.1 milestone May 25, 2021
@etimberg etimberg merged commit 03eb826 into chartjs:master May 25, 2021
@kurkle kurkle deleted the arc-take2 branch May 30, 2021 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonbrunel simonbrunel simonbrunel approved these changes

@etimberg etimberg etimberg approved these changes

Assignees

No one assigned

Labels

type: bug

Projects

None yet

Milestone

Version 3.3.1

Development

Successfully merging this pull request may close these issues.

Label incorrectly positioned with doghnut graph

3 participants

@kurkle @simonbrunel @etimberg