Allow dataset specific ChartMeta type extensions #9432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
commented
Jul 18, 2021
|
|
||
| // A cast is required because the exact type of ChartMeta will vary with | ||
| // mixed charts | ||
| const meta = <ChartMeta<Element, Element, 'doughnut'>>chart.getDatasetMeta(0); |
Member
Author
There was a problem hiding this comment.
I'm not sure if the casting is acceptable here. It would be a lot simpler to cast if TType was the first parameter, but I wasn't sure that would be considered a breaking change or not
Member
There was a problem hiding this comment.
Ideally it should not need to be casted, because its not a mixed chart. I don't know if there is a way to type it so it would return the correct meta for the given dataset index.
kurkle
approved these changes
Jul 19, 2021
kurkle
pushed a commit
to kurkle/chartjs-chart-sankey
that referenced
this pull request
Sep 1, 2021
chartjs/Chart.js#9432 that pull request broke build with ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9422