-
Notifications
You must be signed in to change notification settings - Fork 12k
V2.0 dev skip null fixes #1566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2.0 dev skip null fixes #1566
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok to lose the return?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah
|
Sounds good. As soon as tests pass, this is good to merge 😄 |
This particular part of testing was succeeding in chrome, and failing in firefox. It should be rounded anyway.
The rounding problems compounded in a few areas (like the distanceFromCenter function and drawingArea property). Those are now more accurate.
V2.0 dev skip null fixes
|
I'm curious about the My use case: line chart plotting multiple series, dates on the x-axis. Each series may or may not have a point on a given date. Instead of having the line interrupt, I would prefer to have it join up to the next point! I am currently using Chart.js v2.1.3 in conjunction with http://jtblin.github.io/angular-chart.js/ |
|
So far I have managed to extend the line chart controller and am able to set What can we do to make the line continuous? I'm currently thinking about averaging the surrounding points, plotting a fake point in between (with the averaged values) and hiding the point with |

This fixes bad values from killing the chart.
NaN,undefined, andnullare now all treated the same.skipNullanddrawNullare no longer options in the line element. There weren’t used much, because quite frankly, they didn’t work! Now it’s all automagical, and bad values won’t be drawn.You can still manually skip a point by marking that point’s
_modelwith askip: trueproperty.