Skip to content

/ Chart.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend and title as plugins #2640

Merged
merged 4 commits into from May 28, 2016
Merged

Legend and title as plugins #2640

merged 4 commits into from May 28, 2016

Conversation

@etimberg
Copy link
Member

etimberg commented May 26, 2016

Converts the legend and title block into plugins. This saves some custom code in the core controller.

@simonbrunel @zachpanz88 @tannerlinsley @derekperkins
etimberg added 3 commits May 26, 2016
@etimberg
Legend is attached to the graph as a plugin.
1ae0f5e
@etimberg
Convert title block to a plugin
Loading status checks…
d6289c6
@etimberg
Remove unused code from core controller.
Loading status checks…
46fc96b
@coveralls

This comment has been minimized.

Sign in to view
Copy link

coveralls commented May 26, 2016

Coverage Status

Coverage increased (+0.03%) to 75.495% when pulling 46fc96b on legend-and-title-as-plugins into 8876cd8 on master.
@etimberg

This comment has been minimized.

Sign in to view
Copy link
Member Author

etimberg commented May 26, 2016

Will fix tests tomorrow
@etimberg
Fix tests
Loading status checks…
ae01f17
@coveralls

This comment has been minimized.

Sign in to view
Copy link

coveralls commented May 26, 2016

Coverage Status

Coverage increased (+0.03%) to 75.495% when pulling ae01f17 on legend-and-title-as-plugins into 8876cd8 on master.
@etimberg etimberg merged commit b3f8a53 into master May 28, 2016
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 75.495%
Details
@etimberg etimberg deleted the legend-and-title-as-plugins branch May 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@etimberg @coveralls
You can’t perform that action at this time.