Don’t propagate clicks that are handled internally #3679
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@compwright this PR would need to be rebased |
Prevents the chart `options.onClick` handler from being called if the user clicks on a legend item, for instance. Calling `event.stopImmediatePropagation()` in the legend item click handler would not fix the issue since it is always called after the chart `options.onClick` handler.
compwright
force-pushed
the
fix-click-event
branch
from
e7f6622 to
a31a5ab
Compare
Contributor
Author
|
This approach was obsolesced by #3718. If the issue still exists, it will need another solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the chart
options.onClickhandler from being called if the user clicks on a legend item, for instance. Callingevent.stopImmediatePropagation()in the legend item click handler would not fix the issue since it is always called after the chartoptions.onClickhandler.