Skip to content

remove unnecessary extra init steps #3818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2017
Merged

remove unnecessary extra init steps #3818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/core/core.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,9 @@ module.exports = function(Chart) {
me.resize(true);
}

// Make sure controllers are built first so that each dataset is bound to an axis before the scales
// are built
// Make sure scales have IDs and are built before we build any controllers.
me.ensureScalesHaveIDs();
me.buildOrUpdateControllers();
me.buildScales();
me.updateLayout();
me.resetElements();
me.initToolTip();
me.update();

Copy link
Member

@simonbrunel simonbrunel Jan 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updateLayout() definition method should also be removed, seems only called from that line.

Expand Down Expand Up @@ -256,10 +252,6 @@ module.exports = function(Chart) {
Chart.scaleService.addScalesToLayout(this);
},

updateLayout: function() {
Chart.layoutService.update(this, this.chart.width, this.chart.height);
},

buildOrUpdateControllers: function() {
var me = this;
var types = [];
Expand Down