From 7f8aa8057b9d17624a419725352c4ece0be5d94c Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Sat, 2 Mar 2019 07:07:35 -0800 Subject: [PATCH 1/3] Add a note about how to include an example against master --- .github/ISSUE_TEMPLATE/BUG.md | 8 ++++++-- docs/developers/contributing.md | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/BUG.md b/.github/ISSUE_TEMPLATE/BUG.md index 90ebd643e2b..f62a72753ed 100644 --- a/.github/ISSUE_TEMPLATE/BUG.md +++ b/.github/ISSUE_TEMPLATE/BUG.md @@ -21,13 +21,17 @@ labels: 'type: bug' ## Possible Solution - - + ## Steps to Reproduce (for bugs) ## Context diff --git a/docs/developers/contributing.md b/docs/developers/contributing.md index 15fc938ae09..6ae3e7d4d2a 100644 --- a/docs/developers/contributing.md +++ b/docs/developers/contributing.md @@ -72,6 +72,6 @@ Guidelines for reporting bugs: - Check the issue search to see if it has already been reported - Isolate the problem to a simple test case - - Please include a demonstration of the bug on a website such as [JS Bin](https://jsbin.com/), [JS Fiddle](https://jsfiddle.net/), or [Codepen](https://codepen.io/pen/). ([Template](https://codepen.io/pen?template=JXVYzq)) + - Please include a demonstration of the bug on a website such as [JS Bin](https://jsbin.com/), [JS Fiddle](https://jsfiddle.net/), or [Codepen](https://codepen.io/pen/). ([Template](https://codepen.io/pen?template=JXVYzq)). If filing a bug against `master`, you may reference the latest code via https://www.chartjs.org/dist/master/Chart.min.js (changing the filename to point at the file you need as appropriate). Please provide any additional details associated with the bug, if it's browser or screen density specific, or only happens with a certain configuration or data. From b5fb31301d7462f20bf64acaceb804bd9db86fec Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Sat, 2 Mar 2019 09:30:51 -0800 Subject: [PATCH 2/3] Add a note not to rely on master dist files --- .github/ISSUE_TEMPLATE/BUG.md | 3 ++- docs/developers/contributing.md | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/BUG.md b/.github/ISSUE_TEMPLATE/BUG.md index f62a72753ed..49d265be46a 100644 --- a/.github/ISSUE_TEMPLATE/BUG.md +++ b/.github/ISSUE_TEMPLATE/BUG.md @@ -31,7 +31,8 @@ labels: 'type: bug' If filing a bug against `master`, you may reference the latest code via https://www.chartjs.org/dist/master/Chart.min.js (changing the filename to - point at the file you need as appropriate). + point at the file you need as appropriate). Do not rely on these files for + production purposes as they may be removed at any time. --> ## Context diff --git a/docs/developers/contributing.md b/docs/developers/contributing.md index 6ae3e7d4d2a..6180a3139bc 100644 --- a/docs/developers/contributing.md +++ b/docs/developers/contributing.md @@ -72,6 +72,6 @@ Guidelines for reporting bugs: - Check the issue search to see if it has already been reported - Isolate the problem to a simple test case - - Please include a demonstration of the bug on a website such as [JS Bin](https://jsbin.com/), [JS Fiddle](https://jsfiddle.net/), or [Codepen](https://codepen.io/pen/). ([Template](https://codepen.io/pen?template=JXVYzq)). If filing a bug against `master`, you may reference the latest code via https://www.chartjs.org/dist/master/Chart.min.js (changing the filename to point at the file you need as appropriate). + - Please include a demonstration of the bug on a website such as [JS Bin](https://jsbin.com/), [JS Fiddle](https://jsfiddle.net/), or [Codepen](https://codepen.io/pen/). ([Template](https://codepen.io/pen?template=JXVYzq)). If filing a bug against `master`, you may reference the latest code via https://www.chartjs.org/dist/master/Chart.min.js (changing the filename to point at the file you need as appropriate). Do not rely on these files for production purposes as they may be removed at any time. Please provide any additional details associated with the bug, if it's browser or screen density specific, or only happens with a certain configuration or data. From 7816a9132288cca3ee84bfcec498e3822454e3c8 Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Sat, 2 Mar 2019 09:43:51 -0800 Subject: [PATCH 3/3] Update indentation --- .github/ISSUE_TEMPLATE/BUG.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/BUG.md b/.github/ISSUE_TEMPLATE/BUG.md index 49d265be46a..1d9ca8c2754 100644 --- a/.github/ISSUE_TEMPLATE/BUG.md +++ b/.github/ISSUE_TEMPLATE/BUG.md @@ -21,8 +21,10 @@ labels: 'type: bug' ## Possible Solution - + ## Steps to Reproduce (for bugs)