Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cubicInterpolationMode and changed fill enum #6132

Merged
merged 10 commits into from Apr 8, 2019

Conversation

@stockiNail
Copy link
Contributor

commented Mar 13, 2019

Added cubicInterpolationMode and changed fill enum

Added cubicInterpolationMode and changed fill enum
Added cubicInterpolationMode and changed fill enum
Show resolved Hide resolved docs/configuration/elements.md Outdated

@simonbrunel simonbrunel added this to the Version 2.9 milestone Mar 18, 2019

Changed default value for cubicInterpolationMode
Change the default value for cubicInterpolationMode from an empty string to 'default'.
@benmccann

This comment has been minimized.

Copy link
Collaborator

commented Mar 31, 2019

@stockiNail this PR will need to be rebased

@stockiNail

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

rebased and commited

Show resolved Hide resolved docs/charts/line.md Outdated

@stockiNail stockiNail dismissed stale reviews from etimberg and simonbrunel via 8f64bf6 Apr 2, 2019

Show resolved Hide resolved docs/charts/line.md Outdated
Show resolved Hide resolved docs/configuration/elements.md Outdated
@benmccann
Copy link
Collaborator

left a comment

Thanks for all your patience on this one

@stockiNail

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

Thanks for all your patience on this one

@benmccann no problem at all. Being developer, I love coding (coding is art) but I love a little bit less document..
Having a project which wraps Chart.js, I try to read carefully the documentation to provide all functionalities.
Let me use this thread to add a couple of other items which, in my opinion, we should work on:

  • Controller: reading doc, it's not clear which data structure new controller should prepare. The methods documentation is missing, the methods needed to create data (or other) structure. To create a controller you should go to have a look to other implementation. The example in documentation is the simplest one.
  • New Axis: see above thought about Controller.
  • Default values: I have the feeling there are some other unclear defaults (as I wrote label of dataset on different charts)
  • Charts methods: isDatasetVisible() is not documented but it's very important due to the usage of hidden property is deprecated

GREAT LIBRARY! THANKS!

@simonbrunel simonbrunel requested a review from nagix Apr 3, 2019

@simonbrunel

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

Thanks @stockiNail

Controller... / New Axis...

We first need to standardize input data internally, currently I agree it's a bit chaotic. Basically new controllers / scales should all work on the same date structure, which is not the case currently.

Default values ...

True, we may need another pass on making option tables more consistent.

... isDatasetVisible() ... the usage of hidden property is deprecated

Agreed, this method should be documented in this section. The hidden property isn't deprecated but doesn't represent the effective dataset visibility so that's why most of the time it's better to use this method.

@nagix

nagix approved these changes Apr 4, 2019

Copy link
Collaborator

left a comment

The changes all look good to me!

@simonbrunel simonbrunel merged commit 15d8ac3 into chartjs:master Apr 8, 2019

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 96.641%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.