Make the build reproducible #6817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst working on the Reproducible Builds effort [0] we noticed that Chart.js could not be built reproducibly. This is because it was embedding another build date in a "banner" comment. This patch uses the value from SOURCE_DATE_EPOCH [1] if present. This was originally filed in Debian as #946333 [2]. [0] https://reproducible-builds.org/ [1] https://reproducible-builds.org/specs/source-date-epoch/ [2] https://bugs.debian.org/946333 Signed-off-by: Chris Lamb <lamby@debian.org>
benmccann
approved these changes
Dec 7, 2019
kurkle
approved these changes
Dec 7, 2019
etimberg
approved these changes
Dec 7, 2019
sthagen
added a commit
to sthagen/chartjs-Chart.js
that referenced
this pull request
Dec 7, 2019
Make the build reproducible (chartjs#6817)
tasmo
pushed a commit
to prototypefund/reproducible-website
that referenced
this pull request
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Whilst working on the Reproducible Builds effort we noticed that Chart.js could not be built reproducibly.
This is because it was embedding another build date in a "banner" comment. This patch uses the value from
SOURCE_DATE_EPOCHif present.(This was originally filed in Debian as #946333.)