Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the build reproducible #6817

Conversation

@lamby
Copy link
Contributor

lamby commented Dec 7, 2019

Whilst working on the Reproducible Builds effort we noticed that Chart.js could not be built reproducibly.

This is because it was embedding another build date in a "banner" comment. This patch uses the value from SOURCE_DATE_EPOCH if present.

(This was originally filed in Debian as #946333.)

Whilst working on the Reproducible Builds effort [0] we noticed that
Chart.js could not be built reproducibly.

This is because it was embedding another build date in a "banner"
comment. This patch uses the value from SOURCE_DATE_EPOCH [1] if
present.

This was originally filed in Debian as #946333 [2].

 [0] https://reproducible-builds.org/
 [1] https://reproducible-builds.org/specs/source-date-epoch/
 [2] https://bugs.debian.org/946333

Signed-off-by: Chris Lamb <lamby@debian.org>
@kurkle
kurkle approved these changes Dec 7, 2019
@etimberg etimberg merged commit c4483d1 into chartjs:master Dec 7, 2019
5 checks passed
5 checks passed
build (ubuntu-latest) build (ubuntu-latest)
Details
build (windows-latest) build (windows-latest)
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.299%
Details
@etimberg etimberg added this to the Version 3.0 milestone Dec 7, 2019
sthagen added a commit to sthagen/Chart.js that referenced this pull request Dec 7, 2019
Make the build reproducible (chartjs#6817)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.