Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi series pie example #6919

Merged
merged 1 commit into from Jan 6, 2020

Conversation

etimberg
Copy link
Member

@etimberg etimberg commented Jan 5, 2020

#6273 proposed the addition of a new sample file that showed how to use the legend callbacks in a multi series pie chart.

This PR cleans up the sample and adds to the samples page

@etimberg etimberg added this to the Version 3.0 milestone Jan 5, 2020
Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I'd be interested to see a screenshot out of curiosity

@etimberg
Copy link
Member Author

etimberg commented Jan 5, 2020

multi-series-pie

},
onClick: function(mouseEvent, legendItem) {
// toggle the visibility of the dataset from what it currently is
this.chart.getDatasetMeta(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update these when #6907 gets merged.

@etimberg etimberg merged commit eb116fa into chartjs:master Jan 6, 2020
@etimberg etimberg deleted the add-multi-series-pie-example branch January 19, 2020 18:09
@ineshbose
Copy link

Apologies for the ping on an old PR, but are the tooltips for this example bugged? @etimberg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants