Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve object prototypes when cloning (v2) #7404

Merged
merged 1 commit into from Jun 4, 2020
Merged

Preserve object prototypes when cloning (v2) #7404

merged 1 commit into from Jun 4, 2020

Conversation

@iddings
Copy link

@iddings iddings commented May 22, 2020

This is a backport of #7381, fixing #7340 for v2. Test was modified to support ES5.

@benmccann
Copy link
Collaborator

@benmccann benmccann commented May 22, 2020

I'm not sure that we're going to have another release of 2.9. I'm not against merging this, but the safer route is probably to upgrade to Chart.js 3.0. We're getting close to doing another alpha or beta release that will have the fix

@iddings
Copy link
Author

@iddings iddings commented May 22, 2020

I'm working on upgrading to 3.0, I figured this could go in the next bugfix release on 2.9, but didn't realize such a release wasn't in the plans.

kurkle
kurkle approved these changes May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants