Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix rollup external moment #7587

Merged
merged 1 commit into from Jul 5, 2020
Merged

Conversation

@mojoaxel
Copy link
Contributor

@mojoaxel mojoaxel commented Jul 5, 2020

see https://rollupjs.org/guide/en/#peer-dependencies

Copy link
Collaborator

@benmccann benmccann left a comment

this looks fine to me. we might as well merge it. though i'm not sure it will ever get released because i'm not sure we'll be doing another 2.9 release

@mojoaxel
Copy link
Contributor Author

@mojoaxel mojoaxel commented Jul 5, 2020

though i'm not sure it will ever get released because i'm not sure we'll be doing another 2.9 release

No problem I'm also really really waiting for the v3 release 😉

@etimberg etimberg merged commit 679ec4a into chartjs:2.9 Jul 5, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants