Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When objects are merged together, the target prototype can be polluted. #7918

Merged
merged 2 commits into from Oct 18, 2020

Conversation

@etimberg
Copy link
Member

@etimberg etimberg commented Oct 18, 2020

No description provided.

This change blocks updates to the `__proto__` key during config merge
kurkle
kurkle approved these changes Oct 18, 2020
kurkle
kurkle approved these changes Oct 18, 2020
@simonbrunel
Copy link
Member

@simonbrunel simonbrunel commented Mar 9, 2021

@etimberg @kurkle I think this PR introduced a breaking change when the passed config object is not a plain object (such as reactive data in Vue.js). For example, it breaks the "Events" samples of the datalabels plugin because the listeners options object is not iterable after the merge (example).

@kurkle
Copy link
Collaborator

@kurkle kurkle commented Mar 9, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants