This repository has been archived by the owner. It is now read-only.
rename blacklist{} to dnsbl{} #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This went away when authd was implemented.
aaronmdjones
reviewed
Jul 6, 2020
| { | ||
| blacklists_generic_cancel(auth, "*** No response from DNS blacklists"); | ||
| dnsbls_generic_cancel(auth, "*** No response from DNS dnsbls"); |
There was a problem hiding this comment.
This message is now nonsensical.
aaronmdjones
reviewed
Jul 6, 2020
| { | ||
| blacklists_generic_cancel(auth, "*** Aborting DNS blacklist checks"); | ||
| dnsbls_generic_cancel(auth, "*** Aborting DNS dnsbl checks"); |
aaronmdjones
reviewed
Jul 6, 2020
| { | ||
| blacklists_generic_cancel(auth, "*** Could not check DNS blacklists"); | ||
| dnsbls_generic_cancel(auth, "*** Could not check DNS dnsbls"); |
|
Thanks for cleaning this up @nomis, i haven't had time to do it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Key points:
blacklistandDNSBLin different places to refer to DNSBLs. For various reasons, it is preferable to useDNSBLto refer to DNSBLs.DNSBLand other variants thereof.blacklist{}configuration block is still supported, but a deprecation warning is generated.