This repository has been archived by the owner. It is now read-only.
chmode: use NULL for priv argument when auspex:cmodes priv is not needed #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, sendto_channel_local_priv() will only distribute mode changes to opers only. This is because HasPrivilege(target_p, "") will evaluate as false due to the target not being opered. Thanks to Devin Brown for bisecting this issue.
aaronmdjones
approved these changes
Sep 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Commit d3fd88a introduced
sendto_channel_local_priv()as a useful refactoring of theONLY_OPERShack insendto_channel_local().This works by introducing a new
privargument, which points to a string containing either the required privileges orNULL.The same change, however, sends an empty string as the
privargument for unprivileged modes, causing modes to not be distributed. So we change thatprivargument toNULL.Otherwise,
sendto_channel_local_priv()will only distribute mode changes to opers only. This is becauseHasPrivilege(target_p, "")will evaluate as false due to the target not being opered.Thanks to Devin Brown for bisecting this issue.