{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":131540450,"defaultBranch":"NetHack-3.7","name":"NetHack","ownerLogin":"chasonr","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2018-04-30T00:15:19.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4022333?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1702047196.0","currentOid":""},"activityList":{"items":[{"before":"d7d39688f2893246f91961e84b9c70650b67fe39","after":"b081b388d85706b4c7ad4e72ad740e50265e292c","ref":"refs/heads/interfaces-3.6","pushedAt":"2023-12-26T22:19:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"Changes for Qt 6 and win32 compiling","shortMessageHtmlLink":"Changes for Qt 6 and win32 compiling"}},{"before":"49c24bd6f390110b7026d1b9538b537bd4d96fcf","after":"7b3b716b556589440cfa479d33cf05bb01f3b974","ref":"refs/heads/ports-3.6","pushedAt":"2023-12-26T16:48:11.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"Changes for Qt 6 and other Win32 compile fixes","shortMessageHtmlLink":"Changes for Qt 6 and other Win32 compile fixes"}},{"before":"13e12f9ce913aa98592d0db5109693e8fcb2cae4","after":"49c24bd6f390110b7026d1b9538b537bd4d96fcf","ref":"refs/heads/ports-3.6","pushedAt":"2023-12-25T11:22:34.000Z","pushType":"push","commitsCount":803,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"Merge branch 'ports-3.6' of https://github.com/chasonr/NetHack into ports-3.6","shortMessageHtmlLink":"Merge branch 'ports-3.6' of <a href=\"https://github.com/chasonr/NetHack\">https://github.com/chasonr/NetHack</a> into p…"}},{"before":"b8e2e50d1acbd074db95f192ef32a84f2cb13783","after":"13e12f9ce913aa98592d0db5109693e8fcb2cae4","ref":"refs/heads/ports-3.6","pushedAt":"2023-12-25T11:17:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"Align win10.[ch] with upstream\n\nThese work with MinGW now.","shortMessageHtmlLink":"Align win10.[ch] with upstream"}},{"before":"9bf73bdcd42f2c969c30e8ea96ec4bc7bc51fcbf","after":"d7d39688f2893246f91961e84b9c70650b67fe39","ref":"refs/heads/interfaces-3.6","pushedAt":"2023-12-25T01:20:44.000Z","pushType":"push","commitsCount":102,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"Merge branch 'NetHack-3.6' into interfaces-3.6","shortMessageHtmlLink":"Merge branch 'NetHack-3.6' into interfaces-3.6"}},{"before":"2a9ede0fd70173e3c415b16f318c41fe1df705eb","after":"3bc8af983647a618d714264b071945a38faf90f0","ref":"refs/heads/NetHack-3.7","pushedAt":"2023-12-25T01:14:16.000Z","pushType":"push","commitsCount":161,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"static analyzer bit for wield.c\n\nsrc/wield.c(254): warning: Dereferencing NULL pointer 'wep'.\nSee line 190 for an earlier location where this can occur\n\nThis seems to be a case where an unnecessary null test (A) caused\nthe analyzer to call into question whether or not wep\nis null at (B):\n\n    if (!wep) {\n    } else if (wep->otyp == CORPSE && cant_wield_corpse(wep)) {\n    } else if (uarms && bimanual(wep)) {\n    } else if (!retouch_object(&wep, FALSE)) {\n    } else {\n        /* Weapon WILL be wielded after this point */\n        if (will_weld(wep)) {\n        } else {\n        }\n        if (was_twoweap && !u.twoweap && flags.verbose) {\n        }\n        /* KMH -- Talking artifacts are finally implemented */\nA ==>   if (wep && wep->oartifact) {\n        }\n        if (artifact_light(wep) && !wep->lamplit) {\n        }\nB ==>   if (wep->unpaid) {\n        }\n    }\n\nRemoving the extraneous wep test from (A) resolves the complaint.","shortMessageHtmlLink":"static analyzer bit for wield.c"}},{"before":"3b2d3eabedb983a149f7ab9715c2a8c5499eadaf","after":"2a9ede0fd70173e3c415b16f318c41fe1df705eb","ref":"refs/heads/NetHack-3.7","pushedAt":"2023-12-08T14:54:01.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"ill-formed macro (build fix)","shortMessageHtmlLink":"ill-formed macro (build fix)"}},{"before":"1f52205ee22df6111a88004db936e4677edab66e","after":null,"ref":"refs/heads/vesa-fixes","pushedAt":"2023-12-08T14:53:16.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"}},{"before":"df66ee1ad92972d73da87e1f9e69d4fed9689fd5","after":null,"ref":"refs/heads/fix-exit-crash","pushedAt":"2023-12-08T14:53:12.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"}},{"before":"5dc94f3d83f0a9009e3355403e5b31a6cae8d421","after":"3b2d3eabedb983a149f7ab9715c2a8c5499eadaf","ref":"refs/heads/NetHack-3.7","pushedAt":"2023-12-07T22:09:34.000Z","pushType":"push","commitsCount":20,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"Change wolf, werewolf, and warg colors\n\nThere were 6 brown 'd' monsters; move wolf and werewolf to grey,\nand warg to black, as those colors had no canines.\n\nThe wolf tiles are already greyish; changed warg tile to be\nslightly darker.","shortMessageHtmlLink":"Change wolf, werewolf, and warg colors"}},{"before":null,"after":"df66ee1ad92972d73da87e1f9e69d4fed9689fd5","ref":"refs/heads/fix-exit-crash","pushedAt":"2023-12-07T12:07:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"Avoid calling Curses after it is shut down","shortMessageHtmlLink":"Avoid calling Curses after it is shut down"}},{"before":null,"after":"1f52205ee22df6111a88004db936e4677edab66e","ref":"refs/heads/vesa-fixes","pushedAt":"2023-12-06T14:05:53.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"Fix crashes and weirdness in VESA text mode","shortMessageHtmlLink":"Fix crashes and weirdness in VESA text mode"}},{"before":"006d97e5c83dac7fa70169ced7832a510687cb27","after":"5dc94f3d83f0a9009e3355403e5b31a6cae8d421","ref":"refs/heads/NetHack-3.7","pushedAt":"2023-12-06T13:06:26.000Z","pushType":"push","commitsCount":372,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"Macro for picking random entry from array","shortMessageHtmlLink":"Macro for picking random entry from array"}},{"before":"38546778d5765c596723ac3d3043411f74106756","after":"006d97e5c83dac7fa70169ced7832a510687cb27","ref":"refs/heads/NetHack-3.7","pushedAt":"2023-10-16T02:02:02.000Z","pushType":"push","commitsCount":38,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"github pull request #1108 - new data.base entries\n\nPull request from NullCGT:  a lot of new data.base entries.  Over 20\nseparate commits; this time I didn't squash them together because I\ndidn't want to mess with their log messages.\n\nThree had non-ascii characters where apostrophe or single-quote or\nlong dash are intended.  _The_Invisible_Man_ for stalker was the worst\noffender.  While fixing those, I changed period followed by single\nspace when separating sentences to period followed by two spaces but\ndidn't do that for the other new entires.  A few had trailing spaces and\none existing entry had trailing tabs.  I've fixed up those situations.\n\nThe ice box quote is out of whack with everything else due to wider\nlines but the capitalization indicates that it's from a poem that was\nformatted that way.  I left it as is instead of splitting several of\nthe lines.\n\nThe conical hat entry is iffy since nethack's conical hat is not a\nwide-brimmed witch's hat, but I've left it in.  Likewise helm of\nbrilliance says that it's made of steel but nethack's is now crystal.\n\nCloses #1108","shortMessageHtmlLink":"github pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1927027558\" data-permission-text=\"Title is private\" data-url=\"https://github.com/NetHack/NetHack/issues/1108\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/NetHack/NetHack/pull/1108/hovercard\" href=\"https://github.com/NetHack/NetHack/pull/1108\">NetHack#1108</a> - new data.base entries"}},{"before":"44a649b0b4cbc0f494583887389d41c528df7123","after":"38546778d5765c596723ac3d3043411f74106756","ref":"refs/heads/NetHack-3.7","pushedAt":"2023-10-07T17:12:42.000Z","pushType":"push","commitsCount":51,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"Bigroom 3 may have some walls replaced with other terrain","shortMessageHtmlLink":"Bigroom 3 may have some walls replaced with other terrain"}},{"before":"557e18611a860fa17bbb8e5dbfd37b96c9304fe1","after":"963c3acea7af2c84ddb4697298608f67b6261373","ref":"refs/heads/NetHack-3.6","pushedAt":"2023-09-19T11:04:57.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"avoid crash in curses during #quit\n\nOn GitHub issue 1090, Rhialto wrote:\nHi! I am currently in the process of adapting the pkgsrc packaging of NetHack 3.6.7 to include the curses window option. A bit late perhaps...\n\nWhile working on that, I ran into a case of a NULL pointer being used. Apparently when linking with ncurses, this doesn't cause problems, but NetBSD's own curses doesn't like it, and crashes the game.\n\nHere is the stack trace. It happens when #quitting, I think just before the high scores are about to be shown (but I guess it should show in the stack trace if I'm totally correct with that):\n\n(gdb) bt\n #0  redrawwin (win=0x0) at /usr/src/lib/libcurses/touchwin.c:149\n #1  0x0000000017e104b4 in curses_refresh_nethack_windows () at ../win/curses/curswins.c:176\n #2  0x0000000017e1054a in curses_destroy_win (win=win@entry=0x7ad219520540) at ../win/curses/curswins.c:155\n #3  0x0000000017e1512c in curses_display_nhmenu (wid=<optimized out>, how=<optimized out>, _selected=0x7f7fff65d850) at ../win/curses/cursdial.c:771\n #4  0x0000000017e0ff81 in curses_select_menu (wid=wid@entry=21, how=how@entry=0, selected=selected@entry=0x7f7fff65d850) at ../win/curses/cursmain.c:607\n #5  0x0000000017e10257 in curses_display_nhwindow (wid=21, block=1) at ../win/curses/cursmain.c:385\n #6  0x0000000017ca8075 in really_done (how=<optimized out>, how@entry=13) at end.c:1609\n #7  0x0000000017ca993f in done (how=how@entry=13) at end.c:1201\n #8  0x0000000017ca9c85 in done2 () at end.c:381\n #9  done2 () at end.c:337\n #10 0x0000000017c489da in doextcmd () at cmd.c:363\n #11 0x0000000017c57e94 in rhack (cmd=<optimized out>, cmd@entry=0x0) at cmd.c:4909\n #12 0x0000000017c265da in moveloop (resuming=<optimized out>) at allmain.c:435\n #13 0x0000000017e1b862 in main (argc=<optimized out>, argv=<optimized out>) at ../sys/unix/unixmain.c:351\nstatus_window is NULL here. Simply checking for NULL avoids the problem. I added checks for the other windows as well, while I was there.","shortMessageHtmlLink":"avoid crash in curses during #quit"}},{"before":"43079cf72f69d685578d5f389f80b500e344b8ca","after":"44a649b0b4cbc0f494583887389d41c528df7123","ref":"refs/heads/NetHack-3.7","pushedAt":"2023-09-19T10:31:26.000Z","pushType":"push","commitsCount":167,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"Wand of probing reveals map locations in ray path","shortMessageHtmlLink":"Wand of probing reveals map locations in ray path"}},{"before":"97a1724f177841ca33a2196c088513c8bc172a1d","after":"43079cf72f69d685578d5f389f80b500e344b8ca","ref":"refs/heads/NetHack-3.7","pushedAt":"2023-07-01T07:55:24.000Z","pushType":"push","commitsCount":26,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"paranoid_confirm menu followup\n\nThe command name is expected to be short and the menu description is\nexpected to be short, but use a bigger buffer for the combination of\nthe two just in case.","shortMessageHtmlLink":"paranoid_confirm menu followup"}},{"before":"97a1724f177841ca33a2196c088513c8bc172a1d","after":"43079cf72f69d685578d5f389f80b500e344b8ca","ref":"refs/heads/NetHack-3.7","pushedAt":"2023-07-01T07:55:23.988Z","pushType":"push","commitsCount":26,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"paranoid_confirm menu followup\n\nThe command name is expected to be short and the menu description is\nexpected to be short, but use a bigger buffer for the combination of\nthe two just in case.","shortMessageHtmlLink":"paranoid_confirm menu followup"}},{"before":"fee66f29059e1297522fb25aa5a0b76c2e14c003","after":"97a1724f177841ca33a2196c088513c8bc172a1d","ref":"refs/heads/NetHack-3.7","pushedAt":"2023-06-18T22:08:29.612Z","pushType":"push","commitsCount":5,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"avoid drinksink() complaint from gcc13.1 -fanalyze\n\n'Fix' fountain.c:598:18: warning: check of 'otmp' for NULL after\nalready dereferencing it [-Wanalyzer-deref-before-check]\n\nThe original code was ok.  Either the analyzer has a bug or NONNULL\nin extern.h's 'extern struct obj *mkobj(int, boolean) NONNULL;' is\nnot expanding to the expected value.\n\nThis replacement code should be easier to comprehend and with any\nluck be simpler to analyze.","shortMessageHtmlLink":"avoid drinksink() complaint from gcc13.1 -fanalyze"}},{"before":"fee66f29059e1297522fb25aa5a0b76c2e14c003","after":"97a1724f177841ca33a2196c088513c8bc172a1d","ref":"refs/heads/NetHack-3.7","pushedAt":"2023-06-18T22:08:29.510Z","pushType":"push","commitsCount":5,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"avoid drinksink() complaint from gcc13.1 -fanalyze\n\n'Fix' fountain.c:598:18: warning: check of 'otmp' for NULL after\nalready dereferencing it [-Wanalyzer-deref-before-check]\n\nThe original code was ok.  Either the analyzer has a bug or NONNULL\nin extern.h's 'extern struct obj *mkobj(int, boolean) NONNULL;' is\nnot expanding to the expected value.\n\nThis replacement code should be easier to comprehend and with any\nluck be simpler to analyze.","shortMessageHtmlLink":"avoid drinksink() complaint from gcc13.1 -fanalyze"}},{"before":"82ee37e8e5bdf717659b67deb8e132eae4ff6917","after":null,"ref":"refs/heads/unicode-symsets","pushedAt":"2023-06-16T13:22:21.873Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"}},{"before":"ea84598613f3caebdeca13b0b49ee6b017e99021","after":null,"ref":"refs/heads/unicode-performance","pushedAt":"2023-06-16T13:20:57.889Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"}},{"before":"02276fc724c5a4c707bc7dc81f3ce5f5f1d6d0c8","after":null,"ref":"refs/heads/qt-compatibility","pushedAt":"2023-06-16T13:20:54.675Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"}},{"before":"b7a56b5895db431f8204ce70feb609988ec6af5b","after":null,"ref":"refs/heads/unicode-dangling-pointers","pushedAt":"2023-06-16T13:17:53.048Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"}},{"before":"5a4995d0966c0af9ae616a668f438580cc0503c4","after":null,"ref":"refs/heads/wingui-curses","pushedAt":"2023-06-16T13:17:45.966Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"}},{"before":"199a76eaaad63b74f2be63a430f0b8f812ac0b1a","after":null,"ref":"refs/heads/qt-utf16","pushedAt":"2023-06-16T13:17:43.340Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"}},{"before":"20fb0080127c61511e1761492c80b6961ec81b99","after":null,"ref":"refs/heads/qt-tilewidth","pushedAt":"2023-06-16T13:17:39.861Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"}},{"before":"a5a11c19c9133f7e2b25900ac6f094168665898d","after":"fee66f29059e1297522fb25aa5a0b76c2e14c003","ref":"refs/heads/NetHack-3.7","pushedAt":"2023-06-16T04:00:47.577Z","pushType":"push","commitsCount":21,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"don't hide under statues, statue trap or not\n\nUnlike ground clutter, statues are typically in pretty tight contact\nwith the ground; statue traps are sometimes proclaimed as \"monsters\nposing as statues\".","shortMessageHtmlLink":"don't hide under statues, statue trap or not"}},{"before":"a5a11c19c9133f7e2b25900ac6f094168665898d","after":"fee66f29059e1297522fb25aa5a0b76c2e14c003","ref":"refs/heads/NetHack-3.7","pushedAt":"2023-06-16T04:00:47.472Z","pushType":"push","commitsCount":21,"pusher":{"login":"chasonr","name":null,"path":"/chasonr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4022333?s=80&v=4"},"commit":{"message":"don't hide under statues, statue trap or not\n\nUnlike ground clutter, statues are typically in pretty tight contact\nwith the ground; statue traps are sometimes proclaimed as \"monsters\nposing as statues\".","shortMessageHtmlLink":"don't hide under statues, statue trap or not"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAD0mOE9QA","startCursor":null,"endCursor":null}},"title":"Activity · chasonr/NetHack"}