refactor(sql): do not expose rusqlite Error type in query_map methods #7392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/query_and_then
branch
from
43697ce to
21f33d1
Compare
Collaborator
Author
|
It is a bit strange that our query_map() function now calls query_and_then() internally and has |
link2xt
force-pushed
the
link2xt/query_and_then
branch
2 times, most recently
from
17dd457 to
19192c7
Compare
We use query_and_then() instead of query_map() function now. The difference is that row processing function returns anyhow::Result, so simple fallible processing like JSON parsing can be done inside of it when calling query_map_vec() and query_map_collect() without having to resort to query_map() and iterating over all rows again afterwards.
link2xt
force-pushed
the
link2xt/query_and_then
branch
from
19192c7 to
e72b316
Compare
16 tasks
link2xt
commented
Nov 3, 2025
| where | ||
| F: Send + FnMut(&rusqlite::Row) -> rusqlite::Result<T>, | ||
| G: Send + FnOnce(rusqlite::MappedRows<F>) -> Result<H>, | ||
| F: Send + FnMut(&rusqlite::Row) -> Result<T>, |
Collaborator
Author
There was a problem hiding this comment.
This is the most interesting change, the Result is anyhow::Result here now.
link2xt
commented
Nov 3, 2025
| ) | ||
| .query_map_vec("SELECT entered_param FROM transports", (), |row| { | ||
| let entered_param: String = row.get(0)?; | ||
| let transport: EnteredLoginParam = serde_json::from_str(&entered_param)?; |
Collaborator
Author
There was a problem hiding this comment.
Here you can see how this change is useful, we can now parse JSON with query_map_vec.
iequidoo
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use query_and_then() instead of query_map() function now. The difference is that row processing function
returns anyhow::Result, so simple fallible processing like JSON parsing can be done inside of it
when calling query_map_vec() and query_map_collect() without having to resort to query_map()
and iterating over all rows again afterwards.