[WIP] fix: Correct ordering of securejoin messages #7443
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
reviewed
Nov 14, 2025
| -------------------------------------------------------------------------------- | ||
| Msg#2004: info (Contact#Contact#Info): Establishing guaranteed end-to-end encryption, please wait… [NOTICED][INFO] | ||
| Msg#2003: info (Contact#Contact#Info): Messages are end-to-end encrypted. [NOTICED][INFO] | ||
| Msg#2004: info (Contact#Contact#Info): Establishing guaranteed end-to-end encryption, please wait… [NOTICED][INFO] |
Contributor
There was a problem hiding this comment.
this may regarded as weird.
first saying "Messages are e2ee" and then "establishing e2ee".
maybe the second one should read smth as "Establishing connection, please wait…" this also shorter
Collaborator
Author
There was a problem hiding this comment.
I agree - and also, we don't really talk about "guaranteed end-to-end encryption" anymore, because all end-to-end encryption is guaranteed to last forever now
Edit: Actually, the wording in the UI previously was "Establishing end-to-end encryption, please wait...". Still, I think that "Establishing connection, please wait…" is better; one message talking about e2ee is enough
Collaborator
Author
|
Closing in favor of #7444 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7435
The messages were already added in the way @adbenitez had proposed, but timestamps weren't calculated properly.
Not sure about the approach here - probably we should use calc_sort_timestamp() instead.