feat: Remove the largely-unused ability to send multiple reactions to one message#8131
Merged
Conversation
Hocuri
changed the title
Hocuri
changed the title
Hocuri
force-pushed
the
hoc/remove-multiple-reactions
branch
from
e37cc77 to
3e13994
Compare
Hocuri
changed the title
Hocuri
changed the title
Hocuri
commented
Apr 16, 2026
| }, | ||
| ) | ||
| .await?; | ||
| reactions.retain(|_contact, reaction| !reaction.is_empty()); |
Collaborator
Author
There was a problem hiding this comment.
Previously, the JsonRPC filtered out empty reactions. I don't know whether it's needed, but it can't hurt, and if we do it then it should be done in Core, not the API bindings.
r10s
approved these changes
Apr 16, 2026
Contributor
r10s
left a comment
r10s
left a comment
There was a problem hiding this comment.
lgtm, thanks for the PR.
i also build the PR on iOS and already running it there, works so far :)
…tiple reactions After talking with @r10s, for spring cleaning, remove the different things that can be done a bit. Most messengers do not have this feature, and we do not want to become Matrix where every client has different, partly-incompatible features.
Hocuri
force-pushed
the
hoc/remove-multiple-reactions
branch
from
3e13994 to
be9043f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After talking with @r10s:
For spring cleaning, remove the largely-unused things that can be done a bit.
Most private messengers (WhatsApp/Signal/...) do not have this feature, and we do not want to become Matrix where every client has different, partly-incompatible features.