fix: Don't resort re-sent message to the bottom (#8145)#8152
Merged
Conversation
iequidoo
commented
Apr 21, 2026
| UPDATE msgs SET | ||
| timestamp=( | ||
| SELECT MAX(timestamp) FROM msgs WHERE | ||
| SELECT MAX(timestamp) FROM msgs INDEXED BY msgs_index7 WHERE |
Collaborator
Author
There was a problem hiding this comment.
QUERY PLAN
|--SEARCH msgs USING INTEGER PRIMARY KEY (rowid=?)
`--SCALAR SUBQUERY 1
`--SEARCH msgs USING COVERING INDEX msgs_index7 (state=? AND hidden=? AND chat_id=?)
iequidoo
force-pushed
the
iequidoo/dont-resort-resent-msg
branch
from
562ca3c to
f28fdd5
Compare
link2xt
reviewed
Apr 22, 2026
link2xt
approved these changes
Apr 22, 2026
We shouldn't just revert ad7f873 because then we won't be able to normally transfer a backup from a device having clock a bit in the future. INDEXED BY msgs_index7 is to prevent SQLite from downgrading to using msgs_index2 which has less ordering.
iequidoo
force-pushed
the
iequidoo/dont-resort-resent-msg
branch
from
f28fdd5 to
a67f269
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We shouldn't just revert ad7f873 because then we won't be able to normally transfer a backup from a device having clock a bit in the future.
INDEXED BY msgs_index7 is to prevent SQLite from downgrading to using msgs_index2 which has less ordering.
Fix #8145