fix: Don't receive message if a deletion request was received before (#8143)#8158
Merged
Conversation
…8143) There's no check for `from_id` so another group member can delete the message, but this can only happen in case of message reordering and the problem already exists for usual messages, so we may ignore it and overall a group represents a scope of trust.
iequidoo
force-pushed
the
iequidoo/del-request-reordering
branch
from
0bb08f0 to
34b3f99
Compare
Hocuri
approved these changes
Apr 25, 2026
Comment on lines
+542
to
+544
| // This code handles the download of old partial download stub messages | ||
| // It will be removed after a transitioning period, | ||
| // after we have released a few versions with pre-messages |
Collaborator
There was a problem hiding this comment.
BTW: Not in this PR here, but I think we can remove this code now. Pre-messages have been released since several versions, and nothing terrible happens if downloading a stub message fails (the user can just ask the sender to send it again).
Hocuri
reviewed
Apr 25, 2026
Collaborator
|
FTR, this will only work if the deletion request arrives up to 2 days before the original message, because |
Co-authored-by: Hocuri <hocuri@gmx.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no check for
from_idso another group member can delete the message, but this can only happen in case of message reordering and the problem already exists for usual messages, so we may ignore it and overall a group represents a scope of trust.Fix #8143